Skip to content
This repository has been archived by the owner on Dec 30, 2023. It is now read-only.

refactor(runtime): ♻️ Organize & remove more occurencies of RuntimeError #93

Merged
merged 2 commits into from
May 6, 2023

Conversation

xeho91
Copy link
Member

@xeho91 xeho91 commented May 6, 2023

What is the purpose of this Pull Request?

See Changesets for details.

Type of this Pull Request

  • 🐛 Bug fix
  • ♻️ Code refactoring

@xeho91 xeho91 requested a review from a team May 6, 2023 15:20
@xeho91 xeho91 self-assigned this May 6, 2023
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

🦋 Changeset detected

Latest commit: a8d601f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@terminal-nerds/snippets-runtime Patch
@terminal-nerds/snippets-config Patch
@terminal-nerds/snippets-function Patch
@terminal-nerds/snippets-number Patch
@terminal-nerds/snippets-package Patch
@terminal-nerds/snippets-project Patch
@terminal-nerds/snippets Patch
@terminal-nerds/snippets-array Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ghost
Copy link

ghost commented May 6, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Size Change: +1.62 kB (+1%)

Total Size: 116 kB

Filename Size Change
./packages/runtime/dist/main.cjs 1.69 kB -49 B (-3%)
./packages/runtime/dist/main.js 1.58 kB -51 B (-3%)
./packages/runtime/dist/scope/groups/continuous-integration.cjs 0 B -206 B (removed) 🏆
./packages/runtime/dist/scope/groups/continuous-integration.js 0 B -193 B (removed) 🏆
./packages/runtime/dist/scope/groups/node.cjs 0 B -947 B (removed) 🏆
./packages/runtime/dist/scope/groups/node.js 0 B -935 B (removed) 🏆
./packages/runtime/dist/scope/groups/storybook.cjs 0 B -184 B (removed) 🏆
./packages/runtime/dist/scope/groups/storybook.js 0 B -171 B (removed) 🏆
./packages/runtime/dist/scope/groups/test.cjs 0 B -180 B (removed) 🏆
./packages/runtime/dist/scope/groups/test.js 0 B -168 B (removed) 🏆
./packages/runtime/dist/scope/scope.cjs 1.18 kB -44 B (-4%)
./packages/runtime/dist/scope/scope.js 1.17 kB -47 B (-4%)
./packages/runtime/dist/variable/variable.cjs 920 B -42 B (-4%)
./packages/runtime/dist/variable/variable.js 913 B -38 B (-4%)
./packages/runtime/dist/scope/name.cjs 992 B +992 B (new file) 🆕
./packages/runtime/dist/scope/name.js 981 B +981 B (new file) 🆕
./packages/runtime/dist/scope/scopes/continuous-integration.cjs 206 B +206 B (new file) 🆕
./packages/runtime/dist/scope/scopes/continuous-integration.js 193 B +193 B (new file) 🆕
./packages/runtime/dist/scope/scopes/node.cjs 903 B +903 B (new file) 🆕
./packages/runtime/dist/scope/scopes/node.js 893 B +893 B (new file) 🆕
./packages/runtime/dist/scope/scopes/storybook.cjs 184 B +184 B (new file) 🆕
./packages/runtime/dist/scope/scopes/storybook.js 171 B +171 B (new file) 🆕
./packages/runtime/dist/scope/scopes/test.cjs 180 B +180 B (new file) 🆕
./packages/runtime/dist/scope/scopes/test.js 168 B +168 B (new file) 🆕
ℹ️ View Unchanged
Filename Size
./packages/array/dist/compare/compare.cjs 483 B
./packages/array/dist/compare/compare.js 390 B
./packages/array/dist/difference/difference.cjs 515 B
./packages/array/dist/difference/difference.js 424 B
./packages/array/dist/filter/filter.cjs 371 B
./packages/array/dist/filter/filter.js 353 B
./packages/array/dist/intersection/intersection.cjs 378 B
./packages/array/dist/intersection/intersection.js 363 B
./packages/array/dist/main.cjs 1.53 kB
./packages/array/dist/main.js 1.41 kB
./packages/array/dist/random/random.cjs 473 B
./packages/array/dist/random/random.js 451 B
./packages/array/dist/schema/bigint/bigint.cjs 339 B
./packages/array/dist/schema/bigint/bigint.js 325 B
./packages/array/dist/schema/empty/empty.cjs 238 B
./packages/array/dist/schema/empty/empty.js 228 B
./packages/array/dist/schema/float/float.cjs 328 B
./packages/array/dist/schema/float/float.js 315 B
./packages/array/dist/schema/integer/integer.cjs 588 B
./packages/array/dist/schema/integer/integer.js 566 B
./packages/array/dist/schema/native/native.cjs 207 B
./packages/array/dist/schema/native/native.js 194 B
./packages/array/dist/schema/schema.cjs 894 B
./packages/array/dist/schema/schema.js 877 B
./packages/array/dist/shuffle/shuffle.cjs 470 B
./packages/array/dist/shuffle/shuffle.js 450 B
./packages/array/dist/union/union.cjs 425 B
./packages/array/dist/union/union.js 335 B
./packages/array/dist/unique/unique.cjs 331 B
./packages/array/dist/unique/unique.js 315 B
./packages/config/dist/main.cjs 737 B
./packages/config/dist/main.js 716 B
./packages/config/dist/merge/merge.cjs 199 B
./packages/config/dist/merge/merge.js 187 B
./packages/config/dist/read/read.cjs 677 B
./packages/config/dist/read/read.js 658 B
./packages/error/dist/built-in/built-in.cjs 361 B
./packages/error/dist/built-in/built-in.js 350 B
./packages/error/dist/custom/custom.cjs 415 B
./packages/error/dist/custom/custom.js 328 B
./packages/error/dist/custom/runtime/runtime.cjs 358 B
./packages/error/dist/custom/runtime/runtime.js 274 B
./packages/error/dist/custom/validation/validation.cjs 219 B
./packages/error/dist/custom/validation/validation.js 210 B
./packages/error/dist/main.cjs 602 B
./packages/error/dist/main.js 514 B
./packages/extension/dist/main.cjs 551 B
./packages/extension/dist/main.js 541 B
./packages/extension/dist/schema/groups/html.cjs 218 B
./packages/extension/dist/schema/groups/html.js 201 B
./packages/extension/dist/schema/groups/javascript.cjs 233 B
./packages/extension/dist/schema/groups/javascript.js 221 B
./packages/extension/dist/schema/groups/json.cjs 222 B
./packages/extension/dist/schema/groups/json.js 207 B
./packages/extension/dist/schema/groups/markdown.cjs 227 B
./packages/extension/dist/schema/groups/markdown.js 210 B
./packages/extension/dist/schema/groups/stylesheet.cjs 232 B
./packages/extension/dist/schema/groups/stylesheet.js 221 B
./packages/extension/dist/schema/groups/typescript.cjs 232 B
./packages/extension/dist/schema/groups/typescript.js 220 B
./packages/extension/dist/schema/groups/ui-library.cjs 246 B
./packages/extension/dist/schema/groups/ui-library.js 231 B
./packages/extension/dist/schema/groups/yaml.cjs 219 B
./packages/extension/dist/schema/groups/yaml.js 202 B
./packages/extension/dist/schema/schema.cjs 553 B
./packages/extension/dist/schema/schema.js 543 B
./packages/function/dist/main.cjs 536 B
./packages/function/dist/main.js 528 B
./packages/function/dist/schema/schema.cjs 538 B
./packages/function/dist/schema/schema.js 530 B
./packages/number/dist/main.cjs 1.56 kB
./packages/number/dist/main.js 1.5 kB
./packages/number/dist/math/math.cjs 209 B
./packages/number/dist/math/math.js 198 B
./packages/number/dist/misc/misc.cjs 270 B
./packages/number/dist/misc/misc.js 260 B
./packages/number/dist/random/random.cjs 381 B
./packages/number/dist/random/random.js 370 B
./packages/number/dist/round/round.cjs 269 B
./packages/number/dist/round/round.js 259 B
./packages/number/dist/schema/groups/finite/finite.cjs 221 B
./packages/number/dist/schema/groups/finite/finite.js 209 B
./packages/number/dist/schema/groups/float/float.cjs 236 B
./packages/number/dist/schema/groups/float/float.js 227 B
./packages/number/dist/schema/groups/infinity/infinity.cjs 282 B
./packages/number/dist/schema/groups/infinity/infinity.js 273 B
./packages/number/dist/schema/groups/integer/integer.cjs 292 B
./packages/number/dist/schema/groups/integer/integer.js 282 B
./packages/number/dist/schema/groups/multiple-of/multiple-of.cjs 339 B
./packages/number/dist/schema/groups/multiple-of/multiple-of.js 323 B
./packages/number/dist/schema/groups/nan/nan.cjs 196 B
./packages/number/dist/schema/groups/nan/nan.js 188 B
./packages/number/dist/schema/groups/negative/negative.cjs 269 B
./packages/number/dist/schema/groups/negative/negative.js 260 B
./packages/number/dist/schema/groups/number/number.cjs 271 B
./packages/number/dist/schema/groups/number/number.js 207 B
./packages/number/dist/schema/groups/positive/positive.cjs 272 B
./packages/number/dist/schema/groups/positive/positive.js 262 B
./packages/number/dist/schema/groups/safe/safe.cjs 300 B
./packages/number/dist/schema/groups/safe/safe.js 291 B
./packages/number/dist/schema/groups/zero/zero.cjs 296 B
./packages/number/dist/schema/groups/zero/zero.js 287 B
./packages/number/dist/schema/schema.cjs 1.13 kB
./packages/number/dist/schema/schema.js 1.07 kB
./packages/object/dist/keys/keys.cjs 365 B
./packages/object/dist/keys/keys.js 347 B
./packages/object/dist/main.cjs 500 B
./packages/object/dist/main.js 489 B
./packages/object/dist/merge/merge.cjs 242 B
./packages/object/dist/merge/merge.js 219 B
./packages/object/dist/schema/empty/empty.cjs 229 B
./packages/object/dist/schema/empty/empty.js 219 B
./packages/object/dist/schema/schema.cjs 310 B
./packages/object/dist/schema/schema.js 300 B
./packages/package/dist/dependencies/dependencies.cjs 466 B
./packages/package/dist/dependencies/dependencies.js 444 B
./packages/package/dist/json/json.cjs 325 B
./packages/package/dist/json/json.js 306 B
./packages/package/dist/main.cjs 476 B
./packages/package/dist/main.js 453 B
./packages/package/dist/schema/schema.cjs 78 B
./packages/package/dist/schema/schema.js 63 B
./packages/project/dist/main.cjs 382 B
./packages/project/dist/main.js 363 B
./packages/project/dist/monorepo/monorepo.cjs 382 B
./packages/project/dist/monorepo/monorepo.js 363 B
./packages/regexp/dist/creator/creator.cjs 492 B
./packages/regexp/dist/creator/creator.js 367 B
./packages/regexp/dist/main.cjs 840 B
./packages/regexp/dist/main.js 631 B
./packages/runtime/dist/environment/environment.cjs 679 B
./packages/runtime/dist/environment/environment.js 665 B
./packages/runtime/dist/module/module.cjs 560 B
./packages/runtime/dist/module/module.js 449 B
./packages/runtime/dist/scope/shared.cjs 78 B
./packages/runtime/dist/scope/shared.js 63 B
./packages/snippets/dist/main.cjs 528 B
./packages/snippets/dist/main.js 185 B
./packages/string/dist/case/case.cjs 244 B
./packages/string/dist/case/case.js 87 B
./packages/string/dist/char/char.cjs 1.09 kB
./packages/string/dist/char/char.js 1.07 kB
./packages/string/dist/main.cjs 1.85 kB
./packages/string/dist/main.js 1.66 kB
./packages/string/dist/schema/schema.cjs 282 B
./packages/string/dist/schema/schema.js 270 B
./packages/string/dist/word/word.cjs 284 B
./packages/string/dist/word/word.js 270 B
./packages/test/dist/emoji/emoji.cjs 855 B
./packages/test/dist/emoji/emoji.js 839 B
./packages/test/dist/main.cjs 2.64 kB
./packages/test/dist/main.js 2.63 kB
./packages/test/dist/sample/groups/array.cjs 139 B
./packages/test/dist/sample/groups/array.js 126 B
./packages/test/dist/sample/groups/bigint.cjs 224 B
./packages/test/dist/sample/groups/bigint.js 211 B
./packages/test/dist/sample/groups/boolean.cjs 186 B
./packages/test/dist/sample/groups/boolean.js 175 B
./packages/test/dist/sample/groups/date.cjs 145 B
./packages/test/dist/sample/groups/date.js 133 B
./packages/test/dist/sample/groups/function.cjs 723 B
./packages/test/dist/sample/groups/function.js 709 B
./packages/test/dist/sample/groups/infinity.cjs 152 B
./packages/test/dist/sample/groups/infinity.js 140 B
./packages/test/dist/sample/groups/map.cjs 165 B
./packages/test/dist/sample/groups/map.js 152 B
./packages/test/dist/sample/groups/nan.cjs 128 B
./packages/test/dist/sample/groups/nan.js 116 B
./packages/test/dist/sample/groups/null.cjs 114 B
./packages/test/dist/sample/groups/null.js 102 B
./packages/test/dist/sample/groups/number.cjs 266 B
./packages/test/dist/sample/groups/number.js 258 B
./packages/test/dist/sample/groups/object.cjs 149 B
./packages/test/dist/sample/groups/object.js 135 B
./packages/test/dist/sample/groups/regexp.cjs 138 B
./packages/test/dist/sample/groups/regexp.js 126 B
./packages/test/dist/sample/groups/set.cjs 146 B
./packages/test/dist/sample/groups/set.js 132 B
./packages/test/dist/sample/groups/string.cjs 324 B
./packages/test/dist/sample/groups/string.js 317 B
./packages/test/dist/sample/groups/symbol.cjs 180 B
./packages/test/dist/sample/groups/symbol.js 169 B
./packages/test/dist/sample/groups/undefined.cjs 131 B
./packages/test/dist/sample/groups/undefined.js 119 B
./packages/test/dist/sample/sample.cjs 1.21 kB
./packages/test/dist/sample/sample.js 1.2 kB
./packages/test/dist/unit/unit.cjs 1.45 kB
./packages/test/dist/unit/unit.js 1.44 kB
./packages/type/dist/built-in/built-in.cjs 1.5 kB
./packages/type/dist/built-in/built-in.js 1.49 kB
./packages/type/dist/built-in/groups/control-abstraction.cjs 355 B
./packages/type/dist/built-in/groups/control-abstraction.js 339 B
./packages/type/dist/built-in/groups/error.cjs 323 B
./packages/type/dist/built-in/groups/error.js 308 B
./packages/type/dist/built-in/groups/fundamental.cjs 278 B
./packages/type/dist/built-in/groups/fundamental.js 262 B
./packages/type/dist/built-in/groups/indexed-collection.cjs 397 B
./packages/type/dist/built-in/groups/indexed-collection.js 379 B
./packages/type/dist/built-in/groups/internationalization.cjs 239 B
./packages/type/dist/built-in/groups/internationalization.js 224 B
./packages/type/dist/built-in/groups/keyed-collection.cjs 276 B
./packages/type/dist/built-in/groups/keyed-collection.js 262 B
./packages/type/dist/built-in/groups/managing-memory.cjs 265 B
./packages/type/dist/built-in/groups/managing-memory.js 250 B
./packages/type/dist/built-in/groups/number-and-date.cjs 282 B
./packages/type/dist/built-in/groups/number-and-date.js 270 B
./packages/type/dist/built-in/groups/reflection.cjs 245 B
./packages/type/dist/built-in/groups/reflection.js 227 B
./packages/type/dist/built-in/groups/structured-data.cjs 308 B
./packages/type/dist/built-in/groups/structured-data.js 291 B
./packages/type/dist/built-in/groups/test-processing.cjs 249 B
./packages/type/dist/built-in/groups/test-processing.js 236 B
./packages/type/dist/constructor/constructor.cjs 342 B
./packages/type/dist/constructor/constructor.js 334 B
./packages/type/dist/main.cjs 1.98 kB
./packages/type/dist/main.js 1.96 kB
./packages/type/dist/non-primitive/non-primitive.cjs 361 B
./packages/type/dist/non-primitive/non-primitive.js 348 B
./packages/type/dist/primitive/primitive.cjs 516 B
./packages/type/dist/primitive/primitive.js 504 B
./packages/url/dist/localhost/localhost.cjs 335 B
./packages/url/dist/localhost/localhost.js 323 B
./packages/url/dist/main.cjs 971 B
./packages/url/dist/main.js 960 B
./packages/url/dist/schema/port/port.cjs 303 B
./packages/url/dist/schema/port/port.js 292 B
./packages/url/dist/schema/protocol/protocol.cjs 229 B
./packages/url/dist/schema/protocol/protocol.js 219 B
./packages/url/dist/schema/schema.cjs 448 B
./packages/url/dist/schema/schema.js 436 B
./packages/url/dist/social-media/social-media.cjs 637 B
./packages/url/dist/social-media/social-media.js 634 B
./packages/url/dist/target/target.cjs 367 B
./packages/url/dist/target/target.js 356 B

compressed-size-action

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 4902315903

  • 38 of 45 (84.44%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 95.904%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/runtime/source/scope/scopes/node.ts 1 2 50.0%
packages/runtime/source/variable/variable.ts 6 7 85.71%
packages/runtime/source/scope/name.ts 30 35 85.71%
Totals Coverage Status
Change from base Build 4900054320: -0.002%
Covered Lines: 3247
Relevant Lines: 3343

💛 - Coveralls

@codeclimate
Copy link

codeclimate bot commented May 6, 2023

Code Climate has analyzed commit 70e6d13 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 84.4% (50% is the threshold).

This pull request will bring the total coverage in the repository to 97.1% (0.0% change).

View more on Code Climate.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.4% 86.4% Coverage
0.0% 0.0% Duplication

@xeho91 xeho91 merged commit d86ad4a into main May 6, 2023
@xeho91 xeho91 deleted the fix/runtime-module branch May 6, 2023 15:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants