Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not copy languageMain and languageRoot #206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fritzmg
Copy link
Contributor

@fritzmg fritzmg commented Sep 16, 2021

When you copy an event for instance, the languageMain value should not be copied, since it might end up being copied to the main calendar and then you end up with a main event that still has a languageMain reference to another main event.

@aschempp
Copy link
Member

hmm, thats kinda true. However, if my main language is en and I copy something from fr to de, I want to keep the main language set, otherwise I would need to re-assign all over again. Maybe we need to have an oncopy_callback that prevents such wrong data?

@aschempp aschempp added the bug label Oct 12, 2021
@fritzmg
Copy link
Contributor Author

fritzmg commented Oct 12, 2021

hmm, thats kinda true. However, if my main language is en and I copy something from fr to de, I want to keep the main language set, otherwise I would need to re-assign all over again.

If you copy your main language, it won't automatically have references to itself, will it? Ah, I misread that. Yes, I suppose that use case should be supported 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants