Make nc_notification mandatory for newsletterSubscribeNotificationCenter
#366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #365 (comment)
The
SubscribeControllerdoes not check if a notification was selected:contao-notification_center/src/Controller/FrontendModule/Newsletter/SubscribeController.php
Lines 80 to 82 in 0e8563b
It should not have to, as it does not make sense to use the NC specific module without a notification anyway. Thus instead the
tl_module.nc_notificationfield should simply be mandatory for this front end module.