-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented option to append to an exisiting file #65
Conversation
d6767b3
to
39d9f13
Compare
Looks good |
Can you explain why you changed the checkbox to a dropdown? What are the three different states? Create a new file, overwrite, or append? A blank option seems allowed, but I don't know what it would do? |
It would neither override, nor append = create a new file every time you submit the notification :) |
That's not really clear with the selection, is it? Maybe we should add a blank option label? |
Well it wasn't there until now either. I could have added another checkbox to define if it should append but then you can check not check "override" and check "append" which totally makes no sense^^ But yeah, we could provide a blank option label. |
Either that or include a third option and make the field mandatory (which would be better with the class constants). The current implementation is taken from the Contao file upload field, but that does not support appending so we need to find something new. |
I have updated the PR :) |
👍 |
Implemented option to append to an existing file
This is a PR for #56.
@qzminski and @aschempp, please review.