Add workaround property to fix ctrl+space on devices where this does not work #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it possible to run ctrl+space with hardware keyboards on devices/ROMs where it otherwise is broken. On devices where it already works this workaround breaks ctrl+space though. Where to add this fix was investigated and found by @5bodnar.
|
No objections so merging |
AdamMickiewich
pushed a commit
to VolyaTeam/dzida-app
that referenced
this pull request
Aug 8, 2022
Add workaround property to fix ctrl+space on devices where this does not work
shrihankp
pushed a commit
to reisxd/termux-app
that referenced
this pull request
Oct 20, 2022
Add workaround property to fix ctrl+space on devices where this does not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix (or well, allow user to set a property and thereby fix) #1333.
This is a problem in for example emacs when a user uses a hardware keyboard and wants to mark text by pressing ctrl+space. On some devices pressing ctrl + space currently does nothing, but with PR users that want this functionality can add
ctrl-space-workaround=trueto~/.termux/termux.propertiesand then runtermux-reload-settingsto make ctrl+space work as expected.Confirmed to work on my phone.