-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump(libllvm): 16.0.6 to 17.0.2 #17751
Conversation
Downloaded and ran the AArch build from the CI with the following commands, no problem:
Let me know if you have any issues with any of these LLVM 17 builds, I will keep updating these RC tags until the release. |
3d7ea3b
to
16d256c
Compare
I still need to update the libraries in the |
Damn mobile keyboard. |
@xJonathanLEI or @truboxl, merging this will break the rust package, any one going to get that updated next? I will be updating the Swift package in the next couple days. |
IIUC the |
He has left the Termux org and does not contribute any more: his last commit was two and a half months ago. |
Ah that's said to know. I only ever made two small patches to the |
Have been wondering how come we're still on |
Great, if you are building locally, I suggest applying this pull, downloading these deb files from the CI and putting them in |
Sorry if this is obvious. Can I just checkout to this PR, build |
Sure, that works too, just trying to save you time and disk space by downloading the CI-built packages. 😃 |
Rust need 1.73.0 to work with LLVM 17 Can make an exception to use latest git for Rust I think since I don't see it releasing until October... |
Can that upstream pull simply be applied to the latest rust release instead? |
Sure. I can bump Rust to 1.72.1 first to unblock #17868 then work on Rust 1.72.1 + LLVM 17 patch... |
Alright, this pull is ready, just giving everyone time to work on bumping dependent packages like rust and swift, which I'm working on updating to 5.9, before merging. |
f0d6965
to
dc0d8de
Compare
17.0.2 is out, Swift 5.9 is ready to go. Once rust 1.73.0 is released this week and @truboxl says it is ready to go, I will merge this, then we can get those dependent package updates in. |
6276c1c
to
abf23bc
Compare
Huh, libllvm builds were not completing in Docker anymore, but just did once I shifted the build to the github VM instead. Going to go ahead and merge that pull, while this will wait until rust 1.73 is ready. |
We need to look into bumping all other llvm-dependent packages, like zig or iwyu. @twaik, any interest in helping out with those? |
My current priority is to catch al low hanging fruits 😄 and bump all the packages that is easy to bump. I can fix patch in the case if source of package was modified insignificantly, but I am not sure I am skilled enough to patch such a complicated thing as llvm. |
LLVM is done: the issue now is finding all packages that depend on it and bumping those to rebuild against 17.0.2, if possible. The two major ones, rust and swift, are done, now need to try all the smaller ones that depend on LLVM. |
Reverse dependencies are:
Should I rebuild all of them? |
Many of those are already done; we need to open pulls for the few remaining like ccls and update them if possible. |
Done. There is some problem with wasmedge, for some reason arm build failed. I am not revbumping it. |
Ghc does not want to be built on arm... https://github.com/termux/termux-packages/actions/runs/6529314922/job/17726795890 |
Anything that doesn't work, we'll have to talk to those who maintained it before. We just need to try building each one and check if upstream has a new version that works with LLVM 17, that's it. |
Once this passes CI, download these candidate packages from the CI and test them out for yourself in preparation for the upcoming LLVM 17 release.