Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zls #17758

Merged
merged 1 commit into from
Sep 8, 2023
Merged

Zls #17758

merged 1 commit into from
Sep 8, 2023

Conversation

SunPodder
Copy link
Contributor

No description provided.

@licy183
Copy link
Member

licy183 commented Sep 5, 2023

zls exists in Arch Linux, Gentoo Linux and FreeBSD Ports, so I think it is acceptable to be added for Termux too.

I'd like to merge this PR tomorrow night (UTC+8) if there is no more review.

Copy link
Contributor

@truboxl truboxl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nvm, please hold on while I try to fix the other zig issue

@SunPodder
Copy link
Contributor Author

SunPodder commented Sep 6, 2023

Nvm, please hold on while I try to fix the other zig issue

The zls binary works fine and is ready to be merged. Nothing to be changed on this end.

However, about the zig issues, I also couldn't build zls locally with the zig compiler available in termux. Both of these commands failed

zig build -Dtarget=aarch64-linux-musl -Doptimize=ReleaseSafe
warning: Encountered error: FileNotFound, falling back to default ABI and dynamic linker.

error: TemporaryNameServerFailure
zig build -Doptimize=ReleaseSafe
warning: Encountered error: FileNotFound, falling back to default ABI and dynamic linker.

error: TemporaryNameServerFailure

CI builds works fine though

@truboxl
Copy link
Contributor

truboxl commented Sep 6, 2023

warning: Encountered error: FileNotFound, falling back to default ABI and dynamic linker.

ziglang/zig#14146

error: TemporaryNameServerFailure

ziglang/zig#14636

Likely to be fixed in next version.

But somebody need to step up maintain zig. The original maintainer seems to MIA.
I only bump the zig version because I don't like that last version was left hanging which otherwise would be retired.

Allow me to merge #17768 first so that it fixes x86_64 zls issue too then you can rebase

@truboxl truboxl merged commit 977a4be into termux:master Sep 8, 2023
@SunPodder SunPodder deleted the zls branch September 8, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants