Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(main/rust): 1.73.0 #18027

Merged
merged 3 commits into from
Oct 6, 2023
Merged

bump(main/rust): 1.73.0 #18027

merged 3 commits into from
Oct 6, 2023

Conversation

truboxl
Copy link
Contributor

@truboxl truboxl commented Oct 1, 2023 •
edited
Loading

Close #18164

@truboxl truboxl marked this pull request as draft October 1, 2023 08:48
@finagolfin
Copy link
Member

This is going to time out: you cannot build LLVM and rust on the CI, because each takes about 3+ hours and the limit is 6 hours.

I suggest you build here against LLVM 16 if that helps, but you will have to build locally against LLVM 17.

@truboxl
Copy link
Contributor Author

truboxl commented Oct 1, 2023 •
edited
Loading

Alright. Managed to squeeze CI to finish under 6 hours 😅. Feel free to download the artifacts and test.

https://github.com/termux/termux-packages/actions/runs/6369376277

I will not touch this PR again until LLVM 17 is merged and Rust 1.73.0 is officially released.

@fornwall
Copy link
Member

fornwall commented Oct 5, 2023

Nice getting rid of one of the last python2 build users as well (with the change in config.toml).

@Rhys-T Rhys-T mentioned this pull request Oct 6, 2023
Closed
@truboxl
scripts(lint-packages.sh): allow tilde ~ character
9c72309 
Needed to indicate version prerelease, release candidate, beta etc.
@truboxl
bump(main/rust): 1.73.0
be31e2a
@truboxl
ci(packages.yml): clean up for really large package
9461a84 
Also remove the NDK and ANDROID_HOME enviromment variables since we
never use them after moved to and from Docker image
@truboxl truboxl changed the title DONOTMERGE: bump(main/rust): 1.73.0~beta bump(main/rust): 1.73.0 Oct 6, 2023
@truboxl truboxl marked this pull request as ready for review October 6, 2023 23:10
@truboxl
Copy link
Contributor Author

truboxl commented Oct 6, 2023 •
edited
Loading

I enabled back cleaning up CI for rust. Seems like rust is the space hogger. 😂
/usr/local is omitted from cleaning since that's where GitHub stored it's Android NDK and Android SDK. Probably need to review that later.

Though I think need to revert back to file based grep since the current grep from variable searches wildcard like *rust* instead of exact "rust" which can lead to unwanted behavior. But that will be done separately from this PR or if anyone can help.

@truboxl truboxl merged commit 3a24018 into termux:master Oct 6, 2023
@truboxl truboxl deleted the rust-1.73.0 branch October 6, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finagolfin finagolfin Awaiting requested review from finagolfin

@Grimler91 Grimler91 Awaiting requested review from Grimler91 Grimler91 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't install rust; pkg upgrade tries to remove it if it's already installed (libllvm too new)
3 participants
@truboxl @finagolfin @fornwall