fix(main/binutils-libs): Downgrade a new llvm error so we can keep building. #18813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilding. Saw this in termux#18758. llvm appears to have upgraded a warning to an error (https://reviews.llvm.org/D135402), and while they're not wrong to do so, this package and others (rust-lang/rust#105967) depended on it. This is the simple fix, per the llvm reviews link. Fixes termux#18750.
licy183
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
Actually I'd like to merge this PR with [skip ci]. ctf_label_set and ctf_label_get is declared in bminor/binutils-gdb@6dbf2b7. The author said Notably absent from here (though declared in the API header) is any way to define new labels: this will probably be introduced soon, as part of the linker deduplication work., but these methods to define new labels, namely ctf_label_set and ctf_label_get, have not been introduced yet, and it is not clear whether they will be introduced later. Therefore, I think appending -Wl,--undefined-version to LDFLAGS seems appropriate for this issue.
Tracked by: #18810
bigbio2002
pushed a commit
to bigbio2002/termux-packages
that referenced
this pull request
Feb 27, 2024
…ermux#18813) Saw this in termux#18758. llvm appears to have upgraded a warning to an error (https://reviews.llvm.org/D135402), and while they're not wrong to do so, this package and others (rust-lang/rust#105967) depended on it. This is the simple fix, per the llvm reviews link. Fixes termux#18750 [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this in #18758. llvm appears to have upgraded a warning to an error
(https://reviews.llvm.org/D135402), and while they're not wrong to do
so, this package and others
(rust-lang/rust#105967) depended on it. This
is the simple fix, per the llvm reviews link.
Fixes #18750.