-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package-builder): Update to ubuntu 24.04 #21421
Conversation
ddffe21
to
8d32989
Compare
8d32989
to
447f991
Compare
Thanks, added |
That warning is harmless (llvm is not providing host i386 packages, and we don't need it). But just added 053c24c to avoid that warning now. |
👍 let me know if I can help in any way! |
Thanks but no need, I can handle it myself. |
Avoids a warning on `apt update`: > N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'http://apt.llvm.org/noble llvm-toolchain-noble-17 InRelease' doesn't support architecture 'i386'
053c24c
to
7297ac6
Compare
I've done some more testing and (sort of) everything looks good. I think I can safely close PR #21468. |
Nice, thanks! Let's go for merging this shortly unless anyone has concerns or issues to look into? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worst case we need to roll back these commits.
But this looks all good to me.
Say, another 12 to 24 hours for final feedback?
A random package bump to exercise the CI pipeline after the ubuntu 24.04 update (#21421).
A random package bump to exercise the CI pipeline after the ubuntu 24.04 update (#21421).
A random package bump to exercise the CI pipeline after the ubuntu 24.04 update (termux#21421).
Points of interest from the ubuntu
22.04
->24.04
update:python3
is now3.12
, compared to3.10
previously.python
package is version3.11
and requires a host python of that version, we now use the deadsnakes ppa to install python3.11
, as upstream ubuntu no longer packages that python version.Local testing
I've pushed a prebuilt image of this to docker hub, which can be tested out with:
To build and use the docker image locally with this branch checked out instead: