Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(package-builder): Update to ubuntu 24.04 #21421

Merged
merged 4 commits into from
Sep 21, 2024
Merged

chore(package-builder): Update to ubuntu 24.04 #21421

merged 4 commits into from
Sep 21, 2024

Conversation

fornwall
Copy link
Member

@fornwall fornwall commented Sep 10, 2024

Points of interest from the ubuntu 22.04 -> 24.04 update:

  • System python3 is now 3.12, compared to 3.10 previously.
  • As our python package is version 3.11 and requires a host python of that version, we now use the deadsnakes ppa to install python 3.11, as upstream ubuntu no longer packages that python version.

Local testing

I've pushed a prebuilt image of this to docker hub, which can be tested out with:

CONTAINER_NAME=termux-builder-ubuntu-24.04 TERMUX_BUILDER_IMAGE_NAME=fredrikfornwall/termux-package-builder-ubuntu-24.04 ./scripts/run-docker.sh

To build and use the docker image locally with this branch checked out instead:

(cd scripts && docker build -t my-locally-built-builder . )
CONTAINER_NAME=termux-builder-ubuntu-24.04 TERMUX_BUILDER_IMAGE_NAME=my-locally-built-builder ./scripts/run-docker.sh

scripts/setup-ubuntu.sh Show resolved Hide resolved
scripts/setup-ubuntu.sh Show resolved Hide resolved
@Maxython
Copy link
Member

Maxython commented Sep 14, 2024

I did some testing (package compilation) on the new docker container and there are 3 things I would like to point out:

  1. Need to add installation of python3.12-venv package for termux_setup_python_pip function to work with python3.12.
  2. When executing the command sudo apt update, the following message is displayed, which was not there before (Is this not critical for us?):
    IMG_20240914_160644_477
  3. I need to reconfigure the cgct setup step because the current setup breaks the binaries from the cgt (Cross GCCs for Termux) package in the new docker container.

@fornwall
Copy link
Member Author

fornwall commented Sep 14, 2024

  1. Need to add installation of python3.12-venv package for termux_setup_python_pip function to work with python3.12.

Thanks, added python3.12-venv in b9f8185.

@fornwall
Copy link
Member Author

  1. When executing the command sudo apt update, the following message is displayed, which was not there before (Is this not critical for us?):

That warning is harmless (llvm is not providing host i386 packages, and we don't need it). But just added 053c24c to avoid that warning now.

@fornwall
Copy link
Member Author

  1. I need to reconfigure the cgct setup step because the current setup breaks the binaries from the cgt (Cross GCCs for Termux) package in the new docker container.

👍 let me know if I can help in any way!

@Maxython
Copy link
Member

let me know if I can help in any way!

Thanks but no need, I can handle it myself.

Avoids a warning on `apt update`:

> N: Skipping acquire of configured file 'main/binary-i386/Packages' as repository 'http://apt.llvm.org/noble llvm-toolchain-noble-17 InRelease' doesn't support architecture 'i386'
@Maxython
Copy link
Member

I've done some more testing and (sort of) everything looks good. I think I can safely close PR #21468.

@fornwall
Copy link
Member Author

I've done some more testing and (sort of) everything looks good. I think I can safely close PR #21468.

Nice, thanks! Let's go for merging this shortly unless anyone has concerns or issues to look into?

Copy link
Member

@TomJo2000 TomJo2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worst case we need to roll back these commits.

But this looks all good to me.
Say, another 12 to 24 hours for final feedback?

@fornwall fornwall merged commit 4b9a74a into master Sep 21, 2024
@fornwall fornwall deleted the ubuntu-24.04 branch September 21, 2024 12:37
fornwall added a commit that referenced this pull request Sep 21, 2024
A random package bump to exercise the CI pipeline after the ubuntu 24.04
update (#21421).
fornwall added a commit that referenced this pull request Sep 21, 2024
A random package bump to exercise the CI pipeline after the ubuntu 24.04
update (#21421).
nguynkhn pushed a commit to nguynkhn/termux-packages that referenced this pull request Oct 16, 2024
A random package bump to exercise the CI pipeline after the ubuntu 24.04
update (termux#21421).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants