Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: Update from 13.0.0 to 13.13.0 #4762

Merged
merged 3 commits into from
Apr 19, 2020
Merged

nodejs: Update from 13.0.0 to 13.13.0 #4762

merged 3 commits into from
Apr 19, 2020

Conversation

fornwall
Copy link
Member

@fornwall fornwall commented Jan 7, 2020

Currently does not build, the

g++ -rdynamic -m64 -fPIC  -o /home/builder/.termux-build/nodejs/src/out/Release/mksnapshot [..]

command fails with:

/usr/bin/ld: /home/builder/.termux-build/nodejs/src/out/Release/obj.host/v8_compiler/deps/v8/src/compiler/wasm-compiler.o: in function `v8::internal::compiler::CompileWasmMathIntrinsic(v8::internal::wasm::WasmEngine*, v8::internal::compiler::WasmImportCallKind, v8::internal::Signature<v8::internal::wasm::ValueType>*)':
wasm-compiler.cc:(.text._ZN2v88internal8compiler24CompileWasmMathIntrinsicEPNS0_4wasm10WasmEngineENS1_18WasmImportCallKindEPNS0_9SignatureINS2_9ValueTypeEEE+0xf1): undefined reference to `v8::internal::compiler::InstructionSelector::SupportedMachineOperatorFlags()'
/usr/bin/ld: wasm-compiler.cc:(.text._ZN2v88internal8compiler24CompileWasmMathIntrinsicEPNS0_4wasm10WasmEngineENS1_18WasmImportCallKindEPNS0_9SignatureINS2_9ValueTypeEEE+0xf9): undefined reference to `v8::internal::compiler::InstructionSelector::AlignmentRequirements()'
[...]

Full build output at: https://gist.githubusercontent.com/fornwall/97f40249c718e55e6de162763fe2d6d5/raw/89db0b03b39ccff89e78eefa9b5cd8bf8815625e/error-output.txt

@fornwall
Copy link
Member Author

fornwall commented Jan 7, 2020

Version 13.0.1 of node.js dropped support for building without snapshot:
nodejs/node#30021

@ghost ghost added the WIP Work in progress, do not close the issue (PR) label Jan 10, 2020
@talentlessguy
Copy link

While there is 13.7 already, Termux still has 13.0

any plans on updating it? :)

@danielo515
Copy link

13 is not the stable version. Why do you want to use it?

@Grimler91
Copy link
Member

All arches except x86_64 seem to build fine with 13.12.0

Also blacklist x86_64 for now
@fornwall fornwall changed the title [WIP] Update of node.js to 13.x nodejs: Update from 13.0.0 to 13.13.0 Apr 19, 2020
@fornwall fornwall merged commit 45a22da into master Apr 19, 2020
@fornwall
Copy link
Member Author

@Grimler91 Nice! Blacklisted x86_64 for now and merged this.

@ghost ghost deleted the update-node branch May 2, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in progress, do not close the issue (PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants