Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change SPDX json package download location from NONE to NOASSERTION #1039

Closed
rnjudge opened this issue Sep 24, 2021 · 3 comments · Fixed by #1061
Closed

Change SPDX json package download location from NONE to NOASSERTION #1039

rnjudge opened this issue Sep 24, 2021 · 3 comments · Fixed by #1061
Labels
good first issue A good first issue to tackle if you are new to the project

Comments

@rnjudge
Copy link
Contributor

rnjudge commented Sep 24, 2021

Describe the issue
Tern currently reports the package download location in SPDX reports as NONE In the recent SPDX DocFest, it was discussed that the value should actually be NOASSERTION.

To Reproduce
Steps to reproduce the behavior:

  1. Run `tern report -i -f spdxjson
  2. See downloadLocation is NONE for packages
"downloadLocation": "NONE"

Expected behavior
downloadLocation should be NOASSERTION

To fix
Make changes to tern/formats/spdx/spdxjson/package_helpers.py to change PackageDownloadLocation value to NOASSERTION:

 35         'downloadLocation': mapping['PackageDownloadLocation'] if               
 36         mapping['PackageDownloadLocation'] else 'NOASSERTION',
@rnjudge rnjudge added good first issue A good first issue to tackle if you are new to the project GH Open Source Day Reserved for Grace Hopper Open Source Day participants labels Sep 24, 2021
@KerinPithawala
Copy link
Contributor

Can I work on this issue?

KerinPithawala added a commit to KerinPithawala/tern that referenced this issue Oct 1, 2021
@KerinPithawala
SOLVED ISSUE tern-tools#1039
a35d9d6 
Changed SPDX json package download location from NONE to NOASSERTION as stated in issue description.  Used current upstream and changed the code as mentioned in issue description.
@KerinPithawala
Copy link
Contributor

Thank you for assigning me the issue. Kindly review my Pull Request for the same.

@rnjudge rnjudge removed the GH Open Source Day Reserved for Grace Hopper Open Source Day participants label Oct 19, 2021
KerinPithawala added a commit to KerinPithawala/tern that referenced this issue Oct 20, 2021
@KerinPithawala
Change SPDX pkg download location to NOASSERTION
ed9de57 
Tern currently reports the package download location in SPDX JSON
reports as NONE. In the recent SPDX DocFest, it was discussed that
the value should actually be NOASSERTION.

Resolves tern-tools#1039

Signed-off-by: Kerin Pithawala kerinpithawala7@gmail.com
KerinPithawala added a commit to KerinPithawala/tern that referenced this issue Oct 20, 2021
@KerinPithawala
Change SPDX pkg download location to NOASSERTION
6db3630 
Tern currently reports the package download location in SPDX JSON
reports as NONE. In the recent SPDX DocFest, it was discussed that
the value should actually be NOASSERTION.

Resolves tern-tools#1039

Signed-off-by: Kerin Pithawala kerinpithawala7@gmail.com
KerinPithawala added a commit to KerinPithawala/tern that referenced this issue Oct 20, 2021
@KerinPithawala
Change SPDX pkg download location to NOASSERTION
4dfbd78 
Tern currently reports the package download location in SPDX JSON
reports as NONE. In the recent SPDX DocFest, it was discussed that
the value should actually be NOASSERTION.

Resolves tern-tools#1039

Signed-off-by: Kerin Pithawala kerinpithawala7@gmail.com
@KerinPithawala KerinPithawala mentioned this issue Oct 20, 2021
Merged
@KerinPithawala
Copy link
Contributor

I have made another pull request with one commit. Kindly review my PR for vGHC Open Source Day.

rnjudge pushed a commit that referenced this issue Oct 25, 2021
@KerinPithawala @rnjudge
Change SPDX pkg download location to NOASSERTION
a3e76cd 
Tern currently reports the package download location in SPDX JSON
reports as NONE. In the recent SPDX DocFest, it was discussed that
the value should actually be NOASSERTION.

Resolves #1039

Signed-off-by: Kerin Pithawala kerinpithawala7@gmail.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue A good first issue to tackle if you are new to the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change SPDX pkg download location to NOASSERTION KerinPithawala/tern
2 participants
@rnjudge @KerinPithawala