-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused clean_image_tars function from report.py #1044
Labels
good first issue
A good first issue to tackle if you are new to the project
Comments
nishakm
added
good first issue
A good first issue to tackle if you are new to the project
GH Open Source Day
Reserved for Grace Hopper Open Source Day participants
labels
Sep 27, 2021
Hello! I am taking part in the GHC open-source day and wanted to contribute for this issue |
Rushali-Sarkar
added a commit
to Rushali-Sarkar/tern
that referenced
this issue
Oct 1, 2021
Hi , I am participating in vGHC and would like to work on this issue |
Hi Nisha ,
Yes please assign it to me.
Thanks,
Ashma
…On Fri, Oct 1, 2021 at 11:30 AM Nisha K ***@***.***> wrote:
Hi @Samaiya <https://github.com/Samaiya>, This issue has already been
assigned :). Would you like to take this one instead? #1041
<#1041>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1044 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5CF7PXVHOKM4HL7MYERVTUEX44TANCNFSM5E24BJZA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
rnjudge
removed
the
GH Open Source Day
Reserved for Grace Hopper Open Source Day participants
label
Oct 19, 2021
@rnjudge Can I take this? |
@sayantani11 go for it! |
On it! |
sayantani11
added a commit
to sayantani11/tern
that referenced
this issue
Oct 26, 2021
The clean_image_tars function in report.py has a duplicate in prep.py which is the function to be used when removing image tarballs after analysis. Hence we remove this unused function. Resolves tern-tools#1044 Signed-off by: Sayantani Saha <ii.sayantani.ii@gmail.com>
sayantani11
added a commit
to sayantani11/tern
that referenced
this issue
Oct 26, 2021
The clean_image_tars function in report.py has a duplicate in prep.py which is the function to be used when removing image tarballs after analysis. Hence we remove this unused function. Resolves tern-tools#1044 Signed-off by: Sayantani Saha <ii.sayantani.ii@gmail.com>
rnjudge
pushed a commit
that referenced
this issue
Oct 26, 2021
The clean_image_tars function in report.py has a duplicate in prep.py which is the function to be used when removing image tarballs after analysis. Hence we remove this unused function. Resolves #1044 Signed-off by: Sayantani Saha <ii.sayantani.ii@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WARNING
If this is your first tern contribution, please update your local git settings using these instructions.
DO NOT USE THE GITHUB UI!
When creating your commit message for your PR, make sure to use
git commit -s
rather thangit commit -m
Remember to add a
Fixes: #1044
line in your commit message.Description
The clean_image_tars function in report.py has a duplicate in prep.py which
is the function to be used when removing image tarballs after analysis. Hence
we remove this unused function.
Implementation
Remove the following code block from
tern/report/report.py
:Remember to leave two blank lines between the
write_report
andclean_working_dir
functions.The text was updated successfully, but these errors were encountered: