Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CLI flag to change location of the log file #1113

Closed
rnjudge opened this issue Feb 2, 2022 · 0 comments · Fixed by #1116
Closed

Add CLI flag to change location of the log file #1113

rnjudge opened this issue Feb 2, 2022 · 0 comments · Fixed by #1116
Assignees
@nishakm
Milestone
Beta Release

Comments

@rnjudge
Copy link
Contributor

rnjudge commented Feb 2, 2022

Describe the Feature
Tern currently creates a tern.log file in the directory wherever the Tern command is run that captures the terminal output during a run. Add a CLI flag that could change the location of where the log file ends up.

Use Cases
When running Tern with minikube, it would be to direct the log file to the mount directory instead of leaving it in the container.

Implementation Changes
Add a CLI flag that enables the user to specify a location. If no location is provided, leave the log file in its current directory.
@rnjudge rnjudge added this to the Beta Release milestone Feb 2, 2022
@nishakm nishakm self-assigned this Feb 3, 2022
nishakm pushed a commit to nishakm/tern that referenced this issue Feb 4, 2022
Add option to use custom log file
f470e80 
Some situations require the log files to be written to a different
location than the current working directory. This commit introduces
the option `-l/--log-file` to provide a different file path. To
use this option, run:

tern -l path/to/log/file

In order to enable this functionality, some global logging
variables were moved to the do_main function.

Fixes tern-tools#1113

Signed-off-by: Nisha K <nishak@vmware.com>
@nishakm nishakm mentioned this issue Feb 4, 2022
Merged
nishakm pushed a commit to nishakm/tern that referenced this issue Feb 7, 2022
Add option to use custom log file
364f091 
Some situations require the log files to be written to a different
location than the current working directory. This commit introduces
the option `-l/--log-file` to provide a different file path. To
use this option, run:

tern -l path/to/log/file

In order to enable this functionality, some global logging
variables were moved to the do_main function.

Fixes tern-tools#1113

Signed-off-by: Nisha K <nishak@vmware.com>
rnjudge pushed a commit that referenced this issue Feb 10, 2022
@rnjudge
Add option to use custom log file
8c6115d 
Some situations require the log files to be written to a different
location than the current working directory. This commit introduces
the option `-l/--log-file` to provide a different file path. To
use this option, run:

tern -l path/to/log/file

In order to enable this functionality, some global logging
variables were moved to the do_main function.

Fixes #1113

Signed-off-by: Nisha K <nishak@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nishakm nishakm

Labels
None yet
Projects
None yet
Milestone
Beta Release
Development

Successfully merging a pull request may close this issue.

Add option to use custom log file nishakm/tern
2 participants
@nishakm @rnjudge