Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid SPDXID #1143

Closed
vargenau opened this issue Mar 31, 2022 · 1 comment · Fixed by #1150
Closed

Invalid SPDXID #1143

vargenau opened this issue Mar 31, 2022 · 1 comment · Fixed by #1150

Comments

@vargenau
Copy link
Contributor

Describe the bug
An SPDXID cannot contain underscores.

Tern generates:

SPDXID: SPDXRef-ncurses-terminfo-base-6.2_p20210109-r0

To Reproduce
Steps to reproduce the behavior:

tern report -f spdxtagvalue -i fsfe/reuse:latest -o reuse.spdx

Error in terminal

none

Expected behavior
SPDXID should be valid. Replace "_" with e.g. "-".

Environment you are running Tern on
Enter all that apply

  • Output of 'tern --version'
Tern version 2.9.1

   python version = 3.9.7 (default, Sep 10 2021, 14:59:43)
  • Operating System: Ubuntu 21.10
@rnjudge
Copy link
Contributor

rnjudge commented Mar 31, 2022

Ah, this is because the package version has an underscore in it. I can fix it. Thanks for opening, @vargenau .

@vargenau vargenau mentioned this issue Apr 12, 2022
Closed
rnjudge added a commit to rnjudge/tern that referenced this issue Apr 13, 2022
@rnjudge
Remove underscores from SPDXIDs
df554b8 
An SPDXID is generated using the package name and version metadta. Some
versions, however, contain an underscore in them and an SPDXID cannot
contain an underscore character. This commit replaces underscores in
SPDXIDs with a dash.

Resolves tern-tools#1143

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Signed-off-by: Rose Judge <rjudge@vmware.com>
@rnjudge rnjudge mentioned this issue Apr 13, 2022
Merged
rnjudge added a commit that referenced this issue Apr 13, 2022
@rnjudge
Remove underscores from SPDXIDs
3f00f8c 
An SPDXID is generated using the package name and version metadta. Some
versions, however, contain an underscore in them and an SPDXID cannot
contain an underscore character. This commit replaces underscores in
SPDXIDs with a dash.

Resolves #1143

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
Signed-off-by: Rose Judge <rjudge@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove underscores from SPDXIDs rnjudge/tern
2 participants
@vargenau @rnjudge