Modification of package format for pip #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nishakm I'm okay with this change, wdyt? The sample reports will need to be updated as well but I can do that in another PR. |
|
@ThiefaineM I think your PR commit message is just a little too long for the linting... must be less than 72 characters in the body :) Once you update, this looks good to me. You can ignore the prospector error. |
Packages download with pip or pip3 are taken from the index Pypi. To be more accurate for the purl / in general, it could be better to use Pypi to describe the packages format. Resolves: tern-tools#1130 Signed-off-by: Thiéfaine Mercier <thiefaine.mercier@avisto.com>
ThiefaineM
force-pushed
the
purl-gen-pip
branch
from
9ef267e to
03f4a91
Compare
|
It is updated, sorry for the inconvenience ! |
|
LGTM! |
|
Shoot, @ThiefaineM - I think there is an extra commit attached to this PR now. Can you remove the "Merge branch 'tern-tools:main' into purl-gen-pip" commit? |
|
It's done ! Everything should be okay :) |
ThiefaineM
force-pushed
the
purl-gen-pip
branch
from
bb29864 to
03f4a91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages download with pip or pip3 are taken from the index Pypi.
To be more accurate for the purl / in general, it could be better to use Pypi
to describe the packages format.
Here for the purl for a python component:
The scond one is recognized but not the first.
Resolves: #1130
Signed-off-by: Thiéfaine Mercier thiefaine.mercier@avisto.com