[Feature] Improve oracle spec #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 13, 2020 16:54
…ist param structure to include illiquid factor on denom property
…send associate oracle prevote & vote
Codecov Report
@@ Coverage Diff @@
## develop #325 +/- ##
===========================================
- Coverage 72.87% 71.01% -1.86%
===========================================
Files 73 75 +2
Lines 3089 3605 +516
===========================================
+ Hits 2251 2560 +309
- Misses 731 899 +168
- Partials 107 146 +39 |
added 12 commits
February 13, 2020 18:38
…om oracle slashing, change sdk.DecCoins to types.ExchangeRateTuples on types.AggregateExchangeRateVote
hanjukim
reviewed
Mar 18, 2020
added 2 commits
March 19, 2020 13:58
…atils err for aggregate prevote/vote
yun-yeo
force-pushed
the
feature/improve-oracle-spec
branch
from
c05901d to
1e44cc1
Compare
…revent unnecessary bech32fy works
|
@YunSuk-Yeo instead of |
dokwon
suggested changes
Mar 24, 2020
| @@ -399,7 +399,7 @@ func testAndRunTxs(app *TerraApp) []simulation.WeightedOperation { | |||
| { | |||
| func(_ *rand.Rand) int { | |||
| var v int | |||
| ap.GetOrGenerate(cdc, OpWeightMsgUnjail, &v, nil, | |||
| ap.GetOrGenerate(cdc, OpWeightMsgSend, &v, nil, | |||
There was a problem hiding this comment.
Note: not relevant to oracle improvement, tag along to the PR
dokwon
suggested changes
Mar 25, 2020
dokwon
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Whiteliststruct to includeTobinTaxVoteTargetsin the KeeperThis will enable the voters to do oracle multiple votes with an aggregate msg which is highly downsized compared with normal prevote/vote.
The param structure change will enable to enter illiquid factor, which determines the swap spread, at whitelist registration step via gov proposal.
The core directly refer
params.Whitelistto check oracle slashing at columbus-3. If a new denom is appended toparams.Whitelist, then it can cause some validators miss a oracle vote because it comes middle of a oracle vote period. In order to prevent this confusion, the oracle keeper will keepVoteTargetsand update it at the end of vote period withparams.Whitelist.See discussion: Agora link
Report of required housekeeping
(FOR ADMIN) Before merging