Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Wasm instantiate process #398

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Sep 15, 2020

Summary of changes

Fix to store instantiated contract first before executing response messages, then response messages can utilize instantiated contract.

close #399

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Sep 15, 2020
@yun-yeo yun-yeo added bug Something isn't working must Mustfix for target release. labels Sep 15, 2020
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #398 into develop will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #398   +/-   ##
========================================
  Coverage    66.19%   66.19%           
========================================
  Files          116      116           
  Lines         5887     5887           
========================================
  Hits          3897     3897           
  Misses        1771     1771           
  Partials       219      219           
Impacted Files Coverage Δ
x/wasm/internal/keeper/contract.go 84.89% <100.00%> (ø)

@yun-yeo yun-yeo merged commit 19e4f82 into develop Sep 16, 2020
@yun-yeo yun-yeo deleted the bugfix/wasm-instantiate-process branch September 16, 2020 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working must Mustfix for target release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] WASM contract initialization process
2 participants