Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Prevent panic when external contract query executed #432

Merged
merged 3 commits into from
Nov 23, 2020

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Nov 16, 2020

Summary of changes

External contract query, which is causing out-of-gas, also causes core node panic.
In this PR, I added recover statement to prevent panic from the out-of-gas error.

close #431

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Nov 16, 2020
@yun-yeo yun-yeo added bug Something isn't working enhancement New feature or request labels Nov 16, 2020
@codecov
Copy link

codecov bot commented Nov 16, 2020

Codecov Report

Merging #432 (32bfb4d) into develop (d3c4751) will decrease coverage by 0.00%.
The diff coverage is 70.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #432      +/-   ##
===========================================
- Coverage    67.52%   67.52%   -0.01%     
===========================================
  Files          117      117              
  Lines         5053     5071      +18     
===========================================
+ Hits          3412     3424      +12     
- Misses        1427     1433       +6     
  Partials       214      214              
Impacted Files Coverage Δ
x/wasm/internal/keeper/querier.go 33.73% <70.00%> (+9.11%) ⬆️

@yun-yeo yun-yeo merged commit df11740 into develop Nov 23, 2020
@yun-yeo yun-yeo deleted the bugfix/wasm-query-gas-limit branch November 23, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Out of gas causes panic when external contract store query executed
2 participants