-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Implement read VM pool #546
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yun-yeo
added
enhancement
New feature or request
good first issue
Good for newcomers
wasm
Wasm contract related update
labels
Aug 30, 2021
yun-yeo
changed the title
test purpose readvm pool implementation, still requiring tendermint R…
[Feature] Implement read VM pool
Aug 30, 2021
Codecov Report
@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 44.66% 44.77% +0.11%
==========================================
Files 120 121 +1
Lines 6914 6957 +43
==========================================
+ Hits 3088 3115 +27
- Misses 3588 3596 +8
- Partials 238 246 +8
|
yun-yeo
force-pushed
the
feature/readvm-pool
branch
from
September 1, 2021 14:13
35f7678
to
e99bed3
Compare
should we merge this to #551? |
This should be merged after cosmos-sdk be multi-tread safe (IAVL update) |
hanjukim
previously approved these changes
Sep 22, 2021
octalmage
pushed a commit
to octalmage/core
that referenced
this pull request
Oct 21, 2021
* test purpose readvm pool implementation, still requiring tendermint RWMutex * fix lint * remove data race * remove replace * wrap pool logic with mutex * fix comment * enforce zero readvm config to use default config * bump cosmos-sdk to v0.44.1 * bump cosmwasm to v0.16.1 * cleanup go.mod * changelog update * prevent zero write vm cache * rename the functions * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
close #545
It also contains necessary dependency updates for multi-reader thread implementation.
WASM Config changes
New Configs
write-vm-memory-cache-size
read-vm-memory-cache-size
num-read-vms
Removed Configs
contract-memory-cache-size
We need this two PRs before this.
Report of required housekeeping
(FOR ADMIN) Before merging