Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] remove readvm-pool feature #601

Merged
merged 6 commits into from
Nov 1, 2021
Merged

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Nov 1, 2021

Summary of changes

close #599

Now a wasm VM can handle multi-thread query requests (ref), so we don't need this feature anymore. Also the feature seems make critical issue when loading wasm code into memory.

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo added bug Something isn't working enhancement New feature or request wasm Wasm contract related update labels Nov 1, 2021
@yun-yeo yun-yeo requested a review from hanjukim November 1, 2021 05:12
@yun-yeo yun-yeo self-assigned this Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #601 (113009c) into main (3fcaa62) will decrease coverage by 0.12%.
The diff coverage is 87.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
- Coverage   44.81%   44.69%   -0.13%     
==========================================
  Files         122      120       -2     
  Lines        7013     6967      -46     
==========================================
- Hits         3143     3114      -29     
+ Misses       3626     3614      -12     
+ Partials      244      239       -5     
Impacted Files Coverage Δ
x/wasm/keeper/legacy_querier.go 33.73% <ø> (-1.50%) ⬇️
x/wasm/keeper/querier.go 33.33% <ø> (-2.06%) ⬇️
x/wasm/types/keys.go 0.00% <ø> (ø)
x/wasm/keeper/keeper.go 84.26% <78.94%> (+2.45%) ⬆️
x/wasm/keeper/contract.go 79.84% <100.00%> (+0.31%) ⬆️
x/oracle/tally.go 86.48% <0.00%> (-5.41%) ⬇️

x/wasm/config/config.go Outdated Show resolved Hide resolved
x/wasm/keeper/contract.go Outdated Show resolved Hide resolved
x/wasm/config/config.go Outdated Show resolved Hide resolved
@yun-yeo yun-yeo requested a review from hanjukim November 1, 2021 06:52
@yun-yeo yun-yeo merged commit deae71c into main Nov 1, 2021
@yun-yeo yun-yeo deleted the feature/remove-readvm-pool branch November 1, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request wasm Wasm contract related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] crash with PoisonError and Block.Header.AppHash incorrect
2 participants