Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] fix to charge gas cost for the key length in wasm execution #674

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Feb 6, 2022

Summary of changes

fix - cosmos/cosmos-sdk#10243

This update makes gas KVStore to charge gas cost for the key length to prevent cheap store operation from the contract.
This also requires softfork.

Softfork Schedule

columbus-5 bombay-12
Height 6,470,000 7,800,000
Expected Time 2022-02-13T15:00:00 (UTC) 2022-02-11T15:00:00 (UTC)

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@yun-yeo yun-yeo self-assigned this Feb 6, 2022
@yun-yeo yun-yeo added enhancement New feature or request must Mustfix for target release. urgent Hotfix needed bug Something isn't working labels Feb 6, 2022
@codecov
Copy link

codecov bot commented Feb 6, 2022

Codecov Report

Merging #674 (bd59bd0) into main (f6a968a) will increase coverage by 0.41%.
The diff coverage is 93.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
+ Coverage   45.03%   45.44%   +0.41%     
==========================================
  Files         120      121       +1     
  Lines        7001     7061      +60     
==========================================
+ Hits         3153     3209      +56     
- Misses       3601     3605       +4     
  Partials      247      247              
Impacted Files Coverage Δ
x/wasm/types/gas_store.go 93.33% <93.33%> (ø)
x/wasm/keeper/contract.go 79.84% <100.00%> (ø)

@yun-yeo yun-yeo merged commit 293b023 into main Feb 6, 2022
@yun-yeo yun-yeo deleted the hotfix/use-custom-gas-store-for-wasm-execution branch February 6, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request must Mustfix for target release. urgent Hotfix needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant