Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] make stargatelayer to ensure deterministic response #738

Merged
merged 2 commits into from
May 4, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented Apr 22, 2022

Summary of changes

Implement Stargate layer to ensure deterministic response

Report of required housekeeping

  • Github issue OR spec proposal link
  • Wrote tests
  • Updated API documentation (client/lcd/swagger-ui/swagger.yaml)
  • Added a relevant changelog entry: clog add [section] [stanza] [message]

(FOR ADMIN) Before merging

  • Added appropriate labels to PR
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)
  • Confirm added tests are consistent with the intended behavior of changes
  • Ensure all tests pass

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #738 (bb1e44a) into feature/wasm-1.0 (53f66ce) will decrease coverage by 0.04%.
The diff coverage is 52.94%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##           feature/wasm-1.0     #738      +/-   ##
====================================================
- Coverage             57.89%   57.85%   -0.05%     
====================================================
  Files                    84       85       +1     
  Lines                  3983     3998      +15     
====================================================
+ Hits                   2306     2313       +7     
- Misses                 1475     1479       +4     
- Partials                202      206       +4     
Impacted Files Coverage Δ
x/wasm/stargatelayer/deterministic.go 45.45% <45.45%> (ø)
x/wasm/keeper/wasm_interface_stargate.go 40.00% <66.66%> (+1.53%) ⬆️

@yun-yeo yun-yeo self-assigned this Apr 26, 2022
@yun-yeo yun-yeo added enhancement New feature or request wasm Wasm contract related update labels Apr 26, 2022
@yun-yeo yun-yeo marked this pull request as ready for review April 26, 2022 02:50
@yun-yeo yun-yeo merged commit 0c3ac0f into feature/wasm-1.0 May 4, 2022
@yun-yeo yun-yeo deleted the feature/deterministic-stargate-query branch May 4, 2022 04:45
@mattverse
Copy link

@YunSuk-Yeo what's the reason behind resetting the proto message after finishing marshalling and unmarshalling?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wasm Wasm contract related update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants