Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Reload validator after delegation #16

Merged
merged 1 commit into from
May 25, 2022

Conversation

yun-yeo
Copy link
Contributor

@yun-yeo yun-yeo commented May 25, 2022

When we execute delegate, the staking module's power index logics are working with validator instance what we passed.
If we do not reload the validator instance, the logics are broken and it makes Tendermint to receive duplicate validator power update events.

@yun-yeo yun-yeo self-assigned this May 25, 2022
@yun-yeo yun-yeo requested a review from hanjukim May 25, 2022 04:43
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7c29ae9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage        ?   73.82%           
=======================================
  Files           ?        7           
  Lines           ?      657           
  Branches        ?        0           
=======================================
  Hits            ?      485           
  Misses          ?      147           
  Partials        ?       25           

@yun-yeo yun-yeo merged commit 6779091 into main May 25, 2022
@yun-yeo yun-yeo deleted the bugfix/reload-validator-after-delegate branch May 25, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants