Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: merge mainnet and localnet config.json files and remove unnecessary keys #20

Merged
merged 9 commits into from
Aug 19, 2023

Conversation

AaronCQL
Copy link
Contributor

@AaronCQL AaronCQL commented Aug 10, 2023

PR can be considered done when:

Notes

  • Rename of AppName to Name in app.go is to more closely conform with code scaffolded by ignite CLI

@AaronCQL AaronCQL self-assigned this Aug 10, 2023
@AaronCQL AaronCQL marked this pull request as ready for review August 17, 2023 03:56
@AaronCQL AaronCQL requested a review from yan-wl August 17, 2023 03:57
Copy link
Contributor

@yan-wl yan-wl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AaronCQL AaronCQL merged commit 906b2d5 into main Aug 19, 2023
12 checks passed
@AaronCQL AaronCQL deleted the refactor/simplify-config-json branch August 19, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants