-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2 for columbus-5 and bombay-9 #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: bech32 compatibility
build: 2.0.0-beta.4
Merge branch 'master' into bombay
0xslipk
reviewed
Aug 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two variable (chainID and URL) are everywhere.
const terra = new LCDClient({
chainID: 'bombay-0007',
URL: 'https://bombay-lcd.terra.dev',
});
It will be more cleaner to create const for chain id and URL. That way in the next update we can only change it in one place
I propose export there const from LCDClient.ts something like:
export const LCD_BASE_URL = 'https://lcd.terra.dev';
export const TESTNET_LCD_BASE_URL = 'https://bombay-lcd.terra.dev';
export const TESTNET_CHAIN_ID = 'bombay-0007';
export const CHAIN_ID = 'columbus-4';
hanjukim
added a commit
that referenced
this pull request
Aug 13, 2021
* update for bombay-9 testnet Co-authored-by: Yun Yeo <sw.yunsuk@gmail.com> Co-authored-by: brycepratt <bbsrpratt@gmail.com> Co-authored-by: Jon Lund Steffensen <jonlst@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.