Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2 for columbus-5 and bombay-9 #114

Merged
merged 69 commits into from
Aug 13, 2021
Merged

Release v2 for columbus-5 and bombay-9 #114

merged 69 commits into from
Aug 13, 2021

Conversation

hanjukim
Copy link
Contributor

No description provided.

yun-yeo and others added 30 commits May 6, 2021 17:46
fix: bech32 compatibility
@hanjukim hanjukim marked this pull request as draft August 11, 2021 07:43
Copy link
Contributor

@0xslipk 0xslipk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two variable (chainID and URL) are everywhere.

const terra = new LCDClient({
  chainID: 'bombay-0007',
  URL: 'https://bombay-lcd.terra.dev',
});

It will be more cleaner to create const for chain id and URL. That way in the next update we can only change it in one place

I propose export there const from LCDClient.ts something like:

export const LCD_BASE_URL = 'https://lcd.terra.dev';
export const TESTNET_LCD_BASE_URL = 'https://bombay-lcd.terra.dev';
export const TESTNET_CHAIN_ID = 'bombay-0007';
export const CHAIN_ID = 'columbus-4';

integration-tests/paramchangeproposal.ts Show resolved Hide resolved
src/client/lcd/api/AuthAPI.spec.ts Outdated Show resolved Hide resolved
src/client/lcd/api/TxAPI.ts Outdated Show resolved Hide resolved
src/core/market/params.ts Show resolved Hide resolved
src/core/oracle/params.ts Show resolved Hide resolved
@hanjukim hanjukim marked this pull request as ready for review August 13, 2021 12:21
@hanjukim hanjukim merged commit 34fb928 into master Aug 13, 2021
@hanjukim hanjukim deleted the bombay branch August 13, 2021 12:40
hanjukim added a commit that referenced this pull request Aug 13, 2021
* update for bombay-9 testnet

Co-authored-by: Yun Yeo <sw.yunsuk@gmail.com>
Co-authored-by: brycepratt <bbsrpratt@gmail.com>
Co-authored-by: Jon Lund Steffensen <jonlst@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants