Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Out of gas causes panic when external contract store query executed #431

Closed
yun-yeo opened this issue Nov 16, 2020 · 2 comments · Fixed by #432
Closed

[BUG] Out of gas causes panic when external contract store query executed #431

yun-yeo opened this issue Nov 16, 2020 · 2 comments · Fixed by #432
Assignees
Labels
bug Something isn't working

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Nov 16, 2020

Describe the bug
Core uses gas meter to limit unexpected query DDoS attacks to protect node operators from the external contract query. However, gas meter was made for Tx execution process, so it just occurs panic instead of clean error.

To Reproduce
set query_gas_limit = 0 in wasm.toml and execute query contract-store

Context & versions
v0.4.0

(if applicable) suggested solution
Append recover statement before executing external query

@alpe
Copy link

alpe commented Nov 23, 2020

@YunSuk-Yeo you probably want this fix upstream in wasmd to be safe in the future. Please be so kind and open issues in the wasmd repo as well for the 🐛 🐛 .
Share and care. We generally appreciate any issues/ feedback. ❤️
I have opened an issue for this.

@yun-yeo
Copy link
Contributor Author

yun-yeo commented Nov 30, 2020

@alpe got it I will keep share the problem we can help wasmd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants