Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent certificate recreation #53

Closed
wants to merge 1 commit into from

Conversation

mohsen0
Copy link

@mohsen0 mohsen0 commented Jun 16, 2020

Description

it seems the API returns the values in random order.

      ~ subject_alternative_names = [ # forces replacement
          - "*.example.net",
          - "*.prod.example.com",
            "*.prod-eu-west-1.example.com",
          + "*.example.com",
          + "*.prod.example.net",
        ]

Motivation and Context

Breaking Changes

it might force recreation of the certificate for the last time.

How Has This Been Tested?

yes

Terraform v0.12.26
+ provider.aws v2.66.0
+ provider.kubernetes v1.11.3
+ provider.local v1.4.0
+ provider.null v2.1.2
+ provider.random v2.1.0

@antonbabenko
Copy link
Member

Unfortunately, this is not an acceptable fix for everyone. There are still the same amount of cases when sort is not going to help.

See #20 and hashicorp/terraform-provider-aws#8531 for long discussions.

I am going to close this PR.

@mohsen0 mohsen0 deleted the patch-1 branch June 16, 2020 15:04
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants