Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: convert to dynamic tags to allow for empty values #119

Merged
merged 1 commit into from
Oct 6, 2020
Merged

fix: convert to dynamic tags to allow for empty values #119

merged 1 commit into from
Oct 6, 2020

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Sep 29, 2020

Description

image

Motivation and Context

Breaking Changes

No

How Has This Been Tested?

asg_ec2 example has been updated to include the empty tags and when deployed it works as expected

@antonbabenko antonbabenko merged commit e43c084 into terraform-aws-modules:master Oct 6, 2020
@antonbabenko
Copy link
Member

Thanks, @bryantbiggs !

v3.7.0 has been just released.

@bryantbiggs bryantbiggs deleted the fix/dynamic-empty-tags branch February 21, 2021 20:13
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty value EC2 tag will fail terraform apply
2 participants