Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Removed deprecated option and updated readme - asg deploys #239

Conversation

glangston83
Copy link

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_RequestSpotInstances.html

Description

block_duration_minutes spot instances option is deprecated

Motivation and Context

Removing a deprecated option from request_spot_instances API

Breaking Changes

no

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@glangston83 glangston83 changed the title removed deprecated option and updated readme - asg deploys fix - removed deprecated option and updated readme - asg deploys Jul 21, 2023
@glangston83 glangston83 changed the title fix - removed deprecated option and updated readme - asg deploys fix: removed deprecated option and updated readme - asg deploys Jul 21, 2023
@glangston83 glangston83 changed the title fix: removed deprecated option and updated readme - asg deploys fix: Removed deprecated option and updated readme - asg deploys Jul 21, 2023
@glangston83
Copy link
Author

tested with main code example resulted in terraform apply working setting up ASG, but instances would launch with same error as aleks-fofanov/terraform-gitlab-runner-aws-spot#3

Removed deprecated code and re-tested and spot instances launched

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Aug 21, 2023
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions github-actions bot closed this Aug 31, 2023
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant