Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add log_group_class to log group, bump AWS provider version to 5.x #63

Merged

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Dec 9, 2023

Description

Adds log_group_class to aws_cloudwatch_log_group.
hashicorp/terraform-provider-aws#34679

Motivation and Context

Closes: #62

Breaking Changes

Yes. AWS provider v5 upgrade.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Copy link

@infraimusica infraimusica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Simple task.

@antonbabenko antonbabenko changed the title feat: Add log_group_class to log group feat!: Add log_group_class to log group, bump AWS provider version to 5.x Dec 11, 2023
@antonbabenko
Copy link
Member

@magreenbaum Looks good! Thank you very much for the work. Could you please look at the failed CI run and fix it?

@antonbabenko antonbabenko merged commit d0f3343 into terraform-aws-modules:master Dec 16, 2023
29 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 16, 2023
## [5.0.0](v4.5.0...v5.0.0) (2023-12-16)

### ⚠ BREAKING CHANGES

* Add `log_group_class` to log group, bump AWS provider version to 5.x (#63)

### Features

* Add `log_group_class` to log group, bump AWS provider version to 5.x ([#63](#63)) ([d0f3343](d0f3343))
@antonbabenko
Copy link
Member

This PR is included in version 5.0.0 🎉

@magreenbaum magreenbaum deleted the feat/log_group_class branch January 6, 2024 05:50
Copy link

github-actions bot commented Feb 6, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Support For The "log_group_class" Attribute
3 participants