feat: Adjust optional params for the aws_customer_gateway, add device_name and certificate_arn #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Art3mK
changed the title
|
@antonbabenko could you review, plz 🙏 |
|
ping @antonbabenko 🙏 |
dk1983
approved these changes
Sep 8, 2024
antonbabenko
requested changes
Sep 9, 2024
Art3mK
changed the title
Art3mK
changed the title
|
ping @antonbabenko 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding optional param device_name to the cgw
Motivation and Context
I've got few existing VPN tunnels I'd like to move under tf management, and some cgws have that device_name set, but module doesn't allow to set it. Missing device_name results in cgw recreation.
Breaking Changes
n/a
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestTrivial change, so just tested in my env this solves the problem.