Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use a map for root_block_device instead of list #396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yethal
Copy link

@Yethal Yethal commented Jun 19, 2024

Description

root_block_device variable is now a map instead of list of maps.

Motivation and Context

Since aws_instance resource only allows for a single root_block_device it makes no sense to use a list since it will only ever accept a single element. Moreover storing this configuration in a map instead of wrapping it with a list will make it easier to use with Terragrunt and deep merged configs

Breaking Changes

Yes

Streamline and simplify usage with wrapping automation

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@Yethal Yethal changed the title feat: use a map for root_block_device instead of list feat: Use a map for root_block_device instead of list Jun 19, 2024
@Yethal
Copy link
Author

Yethal commented Jul 23, 2024

@antonbabenko Can we merge this?

@antonbabenko
Copy link
Member

This breaking change brings little improvements, so I don't think we need to introduce it now. Maybe in the future (during the next major release).

@ThickDrinkLots
Copy link

upvote

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 26, 2024
@Yethal
Copy link
Author

Yethal commented Sep 26, 2024

unstale
I'd like to keep this open so it gets merged together with whatever change bumps the major version number

@github-actions github-actions bot removed the stale label Sep 27, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 27, 2024
@Yethal
Copy link
Author

Yethal commented Oct 28, 2024

unstale

@github-actions github-actions bot removed the stale label Oct 29, 2024
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Nov 28, 2024
@Yethal
Copy link
Author

Yethal commented Nov 28, 2024

unstale

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Dec 30, 2024
@Yethal
Copy link
Author

Yethal commented Dec 30, 2024

unstale

@Yethal
Copy link
Author

Yethal commented Dec 30, 2024

@antonbabenko how about a major release on New Year?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants