-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Use a map for root_block_device instead of list #396
base: master
Are you sure you want to change the base?
feat: Use a map for root_block_device instead of list #396
Conversation
@antonbabenko Can we merge this? |
This breaking change brings little improvements, so I don't think we need to introduce it now. Maybe in the future (during the next major release). |
upvote |
This PR has been automatically marked as stale because it has been open 30 days |
unstale |
This PR has been automatically marked as stale because it has been open 30 days |
unstale |
This PR has been automatically marked as stale because it has been open 30 days |
unstale |
This PR has been automatically marked as stale because it has been open 30 days |
unstale |
@antonbabenko how about a major release on New Year? |
Description
root_block_device variable is now a map instead of list of maps.
Motivation and Context
Since aws_instance resource only allows for a single root_block_device it makes no sense to use a list since it will only ever accept a single element. Moreover storing this configuration in a map instead of wrapping it with a list will make it easier to use with Terragrunt and deep merged configs
Breaking Changes
Yes
Streamline and simplify usage with wrapping automation
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request