Add support for IAM task role policy path in ECS service module

[partlythomas]

Describe the solution you'd like.

Similar to how the ECS service module has variable task_exec_iam_policy_path for task execution IAM policies, it would be meaningful to support the same path specification for the IAM tasks role policies as well.

For example as a variable named tasks_iam_policy_path

The variable should then be implemented at resource "aws_iam_role_policy" "tasks" using the path attrribute.

https://github.com/terraform-aws-modules/terraform-aws-ecs/blob/master/modules/service/variables.tf

[partlythomas]

Update: I realize the proposed feature is not compatible with the use of aws_iam_role_policy resource that the module uses for the policy today. I will prepare a Pull Request proposal using the aws_iam_policy resource and explicit attachment resource which is more closely aligned with the pattern that the ECS task execution role uses in the module.

[partlythomas]

Proposed PR related to this issue:
#268

[bryantbiggs]

why do we need all of this just so that a path can be set?

[partlythomas]

@bryantbiggs Because you can't set path for the inline policy type, as it is not an actual separate resource in AWS, but just a part of the role. If you want to separate path for the role and the policy, it can be done so with the proposed changes.

The actual case for this is in environments where governance policies dictates that roles and policies must be created with specific paths. It's sort-of an edge-case, but the changes proposed also aligns with the pattern used by the ECS Task execution role and policy, so for the wider audience that would be the main motivation.

[github-actions]

This issue has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this issue will be closed in 10 days

[github-actions]

This issue was automatically closed because of stale in 10 days

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

[antonbabenko]

This issue has been resolved in version 6.0.0 🎉