Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for easily enabling ECS Exec support #127

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/fargate/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,9 @@ module "ecs_service" {
cpu = 1024
memory = 4096

# Enables ECS Exec
enable_execute_command = true

# Container definition(s)
container_definitions = {

Expand Down
1 change: 1 addition & 0 deletions modules/container-definition/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@ No modules.
| <a name="input_docker_labels"></a> [docker\_labels](#input\_docker\_labels) | A key/value map of labels to add to the container | `map(string)` | `{}` | no |
| <a name="input_docker_security_options"></a> [docker\_security\_options](#input\_docker\_security\_options) | A list of strings to provide custom labels for SELinux and AppArmor multi-level security systems. This field isn't valid for containers in tasks using the Fargate launch type | `list(string)` | `[]` | no |
| <a name="input_enable_cloudwatch_logging"></a> [enable\_cloudwatch\_logging](#input\_enable\_cloudwatch\_logging) | Determines whether CloudWatch logging is configured for this container definition. Set to `false` to use other logging drivers | `bool` | `true` | no |
| <a name="input_enable_execute_command"></a> [enable\_execute\_command](#input\_enable\_execute\_command) | Specifies whether to enable Amazon ECS Exec for the tasks within the service | `bool` | `false` | no |
| <a name="input_entrypoint"></a> [entrypoint](#input\_entrypoint) | The entry point that is passed to the container | `list(string)` | `[]` | no |
| <a name="input_environment"></a> [environment](#input\_environment) | The environment variables to pass to the container | <pre>list(object({<br> name = string<br> value = string<br> }))</pre> | `[]` | no |
| <a name="input_environment_files"></a> [environment\_files](#input\_environment\_files) | A list of files containing the environment variables to pass to a container | <pre>list(object({<br> value = string<br> type = string<br> }))</pre> | `[]` | no |
Expand Down
4 changes: 3 additions & 1 deletion modules/container-definition/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ locals {
var.log_configuration
)

linux_parameters = var.enable_execute_command ? merge({ "initProcessEnabled" : true }, var.linux_parameters) : var.linux_parameters

definition = {
command = length(var.command) > 0 ? var.command : null
cpu = var.cpu
Expand All @@ -37,7 +39,7 @@ locals {
image = var.image
interactive = var.interactive
links = local.is_not_windows && length(var.links) > 0 ? var.links : null
linuxParameters = local.is_not_windows && length(var.linux_parameters) > 0 ? var.linux_parameters : null
linuxParameters = local.is_not_windows && length(local.linux_parameters) > 0 ? local.linux_parameters : null
logConfiguration = length(local.log_configuration) > 0 ? local.log_configuration : null
memory = var.memory
memoryReservation = var.memory_reservation
Expand Down
6 changes: 6 additions & 0 deletions modules/container-definition/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,12 @@ variable "docker_security_options" {
default = []
}

variable "enable_execute_command" {
description = "Specifies whether to enable Amazon ECS Exec for the tasks within the service"
type = bool
default = false
}

variable "entrypoint" {
description = "The entry point that is passed to the container"
type = list(string)
Expand Down
3 changes: 3 additions & 0 deletions modules/service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ module "ecs_service" {
# Disable creation of service and all resources
create = false

# Enable ECS Exec
enable_execute_command = true

# Disable creation of the service IAM role; `iam_role_arn` should be provided
create_iam_role = false

Expand Down
20 changes: 18 additions & 2 deletions modules/service/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -536,6 +536,7 @@ module "container_definition" {
dns_servers = try(each.value.dns_servers, var.container_definition_defaults.dns_servers, [])
docker_labels = try(each.value.docker_labels, var.container_definition_defaults.docker_labels, {})
docker_security_options = try(each.value.docker_security_options, var.container_definition_defaults.docker_security_options, [])
enable_execute_command = try(each.value.enable_execute_command, var.container_definition_defaults.enable_execute_command, var.enable_execute_command)
entrypoint = try(each.value.entrypoint, var.container_definition_defaults.entrypoint, [])
environment = try(each.value.environment, var.container_definition_defaults.environment, [])
environment_files = try(each.value.environment_files, var.container_definition_defaults.environment_files, [])
Expand Down Expand Up @@ -951,7 +952,22 @@ resource "aws_iam_role_policy_attachment" "tasks" {
}

data "aws_iam_policy_document" "tasks" {
count = local.create_tasks_iam_role && length(var.tasks_iam_role_statements) > 0 ? 1 : 0
count = local.create_tasks_iam_role && (length(var.tasks_iam_role_statements) > 0 || var.enable_execute_command) ? 1 : 0

dynamic "statement" {
for_each = var.enable_execute_command ? [1] : []

content {
sid = "ECSExec"
actions = [
"ssmmessages:CreateControlChannel",
"ssmmessages:CreateDataChannel",
"ssmmessages:OpenControlChannel",
"ssmmessages:OpenDataChannel",
]
resources = ["*"]
}
}

dynamic "statement" {
for_each = var.tasks_iam_role_statements
Expand Down Expand Up @@ -996,7 +1012,7 @@ data "aws_iam_policy_document" "tasks" {
}

resource "aws_iam_role_policy" "tasks" {
count = local.create_tasks_iam_role && length(var.tasks_iam_role_statements) > 0 ? 1 : 0
count = local.create_tasks_iam_role && (length(var.tasks_iam_role_statements) > 0 || var.enable_execute_command) ? 1 : 0

name = var.tasks_iam_role_use_name_prefix ? null : local.tasks_iam_role_name
name_prefix = var.tasks_iam_role_use_name_prefix ? "${local.tasks_iam_role_name}-" : null
Expand Down
1 change: 1 addition & 0 deletions wrappers/container-definition/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module "wrapper" {
docker_labels = try(each.value.docker_labels, var.defaults.docker_labels, {})
docker_security_options = try(each.value.docker_security_options, var.defaults.docker_security_options, [])
enable_cloudwatch_logging = try(each.value.enable_cloudwatch_logging, var.defaults.enable_cloudwatch_logging, true)
enable_execute_command = try(each.value.enable_execute_command, var.defaults.enable_execute_command, false)
entrypoint = try(each.value.entrypoint, var.defaults.entrypoint, [])
environment = try(each.value.environment, var.defaults.environment, [])
environment_files = try(each.value.environment_files, var.defaults.environment_files, [])
Expand Down