Skip to content

chore: Update variable name to tag_specifications #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

LuisValdesZero
Copy link
Contributor

@LuisValdesZero LuisValdesZero commented Jan 7, 2025

In service/main.tf it is used a plural tag_specifications name for the attribute

Description

In the service it is used reference for a plural tag_specifications but in variables.tf the variable name is singular tag_specifications, this makes the deployment to break, after changing to plural it works again.

In file modules/service/variables.tf we have singular tag_specification

tag_specification = optional(list(object({

But in modules/service/main.tf we have plural tag_specifications

for_each = managed_ebs_volume.value.tag_specifications != null ? managed_ebs_volume.value.tag_specifications : []

          dynamic "tag_specifications" {
            for_each = managed_ebs_volume.value.tag_specifications != null ? managed_ebs_volume.value.tag_specifications : []

            content {
              resource_type  = tag_specifications.value.resource_type
              propagate_tags = tag_specifications.value.propagate_tags
              tags           = tag_specifications.value.tags
            }
          }

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I deployed an application using the new configuration

In main.tf it is used a plural tag_specifications name for the attribute
@bryantbiggs bryantbiggs merged commit 10c84e8 into terraform-aws-modules:wip/v6 Jan 9, 2025
4 checks passed
Copy link

github-actions bot commented Feb 9, 2025

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants