Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce wg_tags to handle default_tags on provider level #1653

Closed
wants to merge 2 commits into from
Closed

Conversation

kbcz1989
Copy link

PR o'clock

closes: #1578, #1455(?), #1248(?)

Description

When default_tags are used on aws provider level, and the same tags are defined as input to this module, we end up with this issue:
default_tags always shows an update

If "tags" var is not set, no tags will be applied to resources which defines tag_specification.

So, either we have default_tags and do not set "tags". which leaves us with "empty" tag_specifications or we don't use default_tags.

This PR introduces new variable "wg_tags", which will be used on resources which define dynamic tags/tag_specifications if "tags" is not set. Backward compatibility is therefore fully retained.

There will be changes only if wg_tags is set, otherwise the module works the same as before.

Checklist

@kbcz1989 kbcz1989 closed this Oct 20, 2021
@kbcz1989 kbcz1989 reopened this Oct 20, 2021
@kbcz1989 kbcz1989 closed this Oct 20, 2021
@kbcz1989 kbcz1989 reopened this Oct 20, 2021
@kbcz1989 kbcz1989 closed this Oct 20, 2021
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global Tags - Note: Objects have changed outside of Terraform every run
2 participants