Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Replace cluster autoscaler/node termination handler example with Karpenter #1994

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Replace cluster autoscaler/node termination handler example with Karpenter

Motivation and Context

  • Karpenter handles what cluster autoscaler and node termination previously provided and is a more modern, K8 native scaling solution. The example is updated to show users how to setup Karpenter on clusters created by this module as well as the IAM IRSA module

Breaking Changes

  • No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko merged commit 3ff1720 into terraform-aws-modules:master Apr 7, 2022
@bryantbiggs bryantbiggs deleted the docs/karpenter-example branch April 7, 2022 18:48
@antonbabenko
Copy link
Member

This PR is included in version 18.20.0 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
@archoversight
Copy link

aws/karpenter-provider-aws#702 (comment)

This suggests that Karpenter does yet deal with Spot instance termination, so it is not yet a full replacement for NTH.

it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants