Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support default_tags in tag_specifications #2272

Conversation

ivankatliarchuk
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk commented Oct 12, 2022

Description

Default tags not applied to resources like volume,instance and network-interface for self-managed node groups in aws_launch_template

As it looks, there is currently no plans to propagate default tags to tag_specifications in aws provider

Motivation and Context

it fixes similar closed issue

Breaking changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
  • tested in one of the custome cluster as well

@ivankatliarchuk ivankatliarchuk changed the title support default_tags in tag_specifications feat: Support default_tags in tag_specifications Oct 12, 2022
@ivankatliarchuk
Copy link
Contributor Author

ivankatliarchuk commented Oct 12, 2022

closed issue aws provider does not inherit default tags for launch template for specific resources. I know it was closed, but maintaining a fork for this module is not great idea. Would like to know how can I prove that its required to be set explicitly?

@ivankatliarchuk
Copy link
Contributor Author

ivankatliarchuk commented Oct 12, 2022

Source code. There is no tag propagation here. It looks like a bug, to me, would be nice to support this functionality on module level while there is still inconsistent in default tags behaviour

@bryantbiggs
Copy link
Member

I don't think we will be entertaining any further changes for default tags due to the number of issues #2264

default tags should be just that - default tags. If you have to start adding support for default tags into your resources and modules than its no longer default tags, its just tags. these issues are better addressed at the provider level since that is where the implementation is controlled https://github.com/hashicorp/terraform-provider-aws/issues?q=is%3Aissue+is%3Aopen+default+tags+sort%3Areactions-%2B1-desc

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants