-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DescribeParameter always needs full access #354
Conversation
|
@bryantbiggs This is a follow up to: #348 |
This is the final policy json when setting external_secrets_ssm_parameter_arns and external_secrets_secrets_manager_arns
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had thought it was going to require wildcard, at least we tried to scope it! Thanks for the PR!
This PR is included in version 5.14.4 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Just like ListSecrets from Secrets Manager the DecribeParameter action is always required to allow full access
Motivation and Context
With out this the policy will not work when using the external_secrets_ssm_parameter_arns variable
Breaking Changes
no
How Has This Been Tested?
pre-commit run -a
on my pull request