fix: Ensure role_name_condition is set correctly
#389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstiri
changed the title
mstiri
changed the title
mstiri
changed the title
mstiri
changed the title
1 task
bryantbiggs
reviewed
Jun 4, 2023
|
Is this going to get merged and released? |
bryantbiggs
changed the title
role_name_condition is set correctly
bryantbiggs
approved these changes
Jun 29, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Jun 29, 2023
### [5.23.1](v5.23.0...v5.23.1) (2023-06-29) ### Bug Fixes * Ensure `role_name_condition` is set correctly ([#389](#389)) ([0024928](0024928))
|
This PR is included in version 5.23.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the
iam-role-for-service-accounts-eksmodule with theallow_self_assume_roleset totruea dynamic statement is generated for the policy. This policy uses a local role_name_condition computed using the coalesce function as follows:coalesce(var.role_name, "${var.role_name_prefix}*")The issue comes from the fact that the
var.role_name_prefixisnullby default, and cannot be included in a string template. The error generated is:The expression result is null. Cannot include a null value in a string template.Motivation and Context
This change solves the issue generated when the
allow_self_assume_roleset totrue. It is a fix to handle the different cases properlyBreaking Changes
The PR does not introduce any breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsChanges have been tested by creating a new example taking the
module.cert_manager_irsa_roleas a base and settingallow_self_assume_roletotrue. The new example is included in the PR to make sure this case is always properly handled, it is undermodule.cert_manager_irsa_role_self_assumeThe original example has been tested with the new changes to make sure nothing is broken.
pre-commit run -aon my pull request