Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update hashicorp/aws module to >= 5.0 #483

Closed
wants to merge 1 commit into from

Conversation

casdr
Copy link

@casdr casdr commented May 8, 2024

Description

This updates hashicorp/aws to the latest version and makes it compatible with the other modules provided by terraform-aws-modules.

Motivation and Context

Currently it's impossible to use the latest version a lot of other modules provided by terraform-aws-modules, as most of them depend on hasicorp/aws >= 5.0. The current version of terraform-aws-iam depends on >= 4.0.

Breaking Changes

I've tested this against some of the examples and our internal projects and didn't notice any breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@casdr casdr marked this pull request as ready for review May 8, 2024 12:43
@casdr casdr changed the title update hashicorp/aws module to >= 5.0 chore: update hashicorp/aws module to >= 5.0 May 8, 2024
@casdr casdr changed the title chore: update hashicorp/aws module to >= 5.0 chore: update hashicorp aws module May 8, 2024
@casdr casdr changed the title chore: update hashicorp aws module chore: Update hashicorp/aws module to >= 5.0 May 8, 2024
@bryantbiggs
Copy link
Member

This is not required - we specify a minimum requirement, you can use any version greater than this minimum required version

@bryantbiggs bryantbiggs closed this May 8, 2024
@casdr casdr deleted the cdr/update-aws branch May 8, 2024 13:05
@casdr
Copy link
Author

casdr commented May 8, 2024

Ah whoops, you're correct @bryantbiggs. The dependency issues were from another module. Sorry!

Copy link

github-actions bot commented Jun 8, 2024

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants