Update comments in examples/ about aws_kms_ciphertext (#12)

terraform-aws-modules · Jun 5, 2018 · 7c22b76 · 7c22b76
1 parent 8cd1901
commit 7c22b76
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/examples/cloudwatch-alerts-to-slack/main.tf b/examples/cloudwatch-alerts-to-slack/main.tf
@@ -6,7 +6,8 @@ variable "kms_key_arn" {
   default = "arn:aws:kms:eu-west-1:000014191260:key/66db1c5d-d42b-4e28-8efb-07a9cf607a73"
 }
 
-# Encrypt the URL, this is an example, in practice encryption should not be done here as it will be shown in logs and end up in Terraform state file
+# Encrypt the URL, storing encryption here will show it in logs and in tfstate
+# https://www.terraform.io/docs/state/sensitive-data.html
 data "aws_kms_ciphertext" "slack_url" {
   plaintext = "https://hooks.slack.com/services/AAA/BBB/CCC"
   key_id    = "${var.kms_key_arn}"

diff --git a/examples/notify-slack-kms/main.tf b/examples/notify-slack-kms/main.tf
@@ -6,7 +6,8 @@ variable "kms_key_arn" {
   default = "arn:aws:kms:eu-west-1:000014191260:key/66db1c5d-d42b-4e28-8efb-07a9cf607a73"
 }
 
-# Encrypt the URL, this is an example, in practice encryption should not be done here as it will be shown in logs and end up in Terraform state file
+# Encrypt the URL, storing encryption here will show it in logs and in tfstate
+# https://www.terraform.io/docs/state/sensitive-data.html
 data "aws_kms_ciphertext" "slack_url" {
   plaintext = "https://hooks.slack.com/services/AAA/BBB/CCC"
   key_id    = "${var.kms_key_arn}"