Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plan/apply run from different control nodes #27

Closed
wants to merge 6 commits into from

Conversation

jinnko
Copy link
Contributor

@jinnko jinnko commented Feb 7, 2019

When running the terraform plan/apply from different workstatons or build servers we found that the lambda filename attribute was still a fully qualified path that didn't always exist on each control node. The fixes to use relative paths hadn't been applied to the state file for resources that had previously existed. To resolve this we had to stop ignoring the filename attribute. To get to that point it was easier to reason about the paths by removing the indirection on the file references.

Tested this across different workstations and we're getting the desired results now. Subsequent runs also aren't resulting in any further changes.

In order to reliably carry out testing we've also added a test framework for the lambda along with instructions. As part of this we needed to capture some incoming events, so the lambda now also has an option to log the raw incoming events.

The used python version has also been updated to 3.7 because it's available, considered stable, and works.

Please see individual commit messages for further details.

Verified

This commit was signed with the committer’s verified signature. The key has expired and has been revoked.
jinnko Jinn Koriech

Verified

This commit was signed with the committer’s verified signature. The key has expired and has been revoked.
jinnko Jinn Koriech
Now that we're using relative paths to the lambda script/zip we don't
need to be ignoring the filename field.  In any case, this causes
script updates to fail.

Verified

This commit was signed with the committer’s verified signature. The key has expired and has been revoked.
jinnko Jinn Koriech
The lambda gets local tests we can use to confirm we're handling events
correctly.  In particular, events generated by Log Metrics appear to
have a slightly different format.

Response returned by the script now provides insight into the webhook
response from Slack.

We also have a new env var supported that allows us to enable incoming
event logging for all events.  Even if this is off, failure to handle an
event should still result in the event message being logged.

Verified

This commit was signed with the committer’s verified signature. The key has expired and has been revoked.
jinnko Jinn Koriech
Update to use python-3.7 runtime because it's stable and available.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@noqqe
Copy link

noqqe commented Sep 18, 2019

Please merge! :)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@jinnko
Copy link
Contributor Author

jinnko commented Sep 18, 2019

Conflicts resolved. Let me know if there's anything I can do to help get this merged.

antonbabenko added a commit that referenced this pull request Dec 20, 2019
antonbabenko added a commit that referenced this pull request Dec 20, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@antonbabenko
Copy link
Member

Big thanks @jinnko!

v2.6.0 has been released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants