Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for ap-southeast-3 region #6

Merged
merged 2 commits into from
Dec 17, 2021
Merged

feat: Added support for ap-southeast-3 region #6

merged 2 commits into from
Dec 17, 2021

Conversation

markandersontrocme
Copy link
Contributor

Description

Adding support for the new region so that the pricing module works again.

Motivation and Context

Adding support for the new region: https://aws.amazon.com/blogs/aws/now-open-aws-asia-pacific-jakarta-region/
Closes #5

Breaking Changes

How Has This Been Tested?

  • [ x] I have tested and validated these changes using one or more of the provided examples/* projects

I tested with the pricing-resources example

@markandersontrocme
Copy link
Contributor Author

@antonbabenko can you please take a look

modules/pricing/regions.tf Outdated Show resolved Hide resolved
modules/pricing/regions.tf Outdated Show resolved Hide resolved
modules/pricing/regions.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title adding ap-southeast-3 region feat: Added support for ap-southeast-3 region Dec 17, 2021
@antonbabenko antonbabenko merged commit 3041d75 into terraform-aws-modules:master Dec 17, 2021
antonbabenko pushed a commit that referenced this pull request Dec 17, 2021
# [1.3.0](v1.2.0...v1.3.0) (2021-12-17)

### Bug Fixes

* Skip region ap-northeast-3 ([2691463](2691463))
* update CI/CD process to enable auto-release workflow ([#4](#4)) ([a80f318](a80f318))

### Features

* Added GH Actions for sem release ([f406bbc](f406bbc))
* Added support for ap-southeast-3 region ([#6](#6)) ([3041d75](3041d75))
@antonbabenko
Copy link
Member

This PR is included in version 1.3.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: region not found for name: ap-southeast-3
2 participants