Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Specify type as egress for security group rules in example #455

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

realfredlai
Copy link
Contributor

@realfredlai realfredlai commented Jul 9, 2024

Specify type as egress for security group rules in postgresql egress example

Description

Correct security_group_rules example to specify type = "egress" for egress rules.

Motivation and Context

By default the type is ingress, while for egress rule it's required to explicitly specify the type.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs changed the title fix: Specify type as egress for security group rules in example docs: Specify type as egress for security group rules in example Jul 9, 2024
@bryantbiggs bryantbiggs merged commit e9eb2b6 into terraform-aws-modules:master Jul 9, 2024
16 checks passed
@antonbabenko
Copy link
Member

This PR is included in version 9.5.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants