Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for ca_cert_identifier for the upcoming RDS cert updat… #98

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

acholt
Copy link
Contributor

@acholt acholt commented Jan 13, 2020

…e on 5 March 2020 (#91)

Description

Adding support to specify and update the "Certificate authority" on RDS for the upcoming certificate rotation by AWS. The default is "rds-ca-2019".

@bhegazy
Copy link

bhegazy commented Jan 21, 2020

any chance we can merge this? @antonbabenko

@danylohetmantsev
Copy link

Right now ca-2019 became a default parameter for all rds instances created after January 14.

@bhegazy @acholt

Copy link

@Haimi Haimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly how we implemented it in our project. Should be default.

@antonbabenko antonbabenko merged commit 2b793d9 into terraform-aws-modules:master Feb 26, 2020
@antonbabenko
Copy link
Member

Thanks @acholt for this addition!

v2.16.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants