Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terraform 0.11.14 fmt issue with examples/enhanced-monitoring/main.tf #160

Closed
jeohist opened this issue Aug 27, 2019 · 2 comments
Closed

Comments

@jeohist
Copy link

jeohist commented Aug 27, 2019

I was updating the version of the terraform-aws-rds module in our repositories and noticed that since version v1.29.0, it requires a terraform fmt on examples/enhanced-monitoring/main.tf in combination with Terraform 0.11.14. It looks like there were some formatting changes in that file to prepare it for Terraform 0.12, but the change in commit 05360c2 changing

maintenance_window      = "Mon:00:00-Mon:03:00"
  backup_window           = "03:00-06:00"
  backup_retention_period = 0 // disable backups to create DB faster

  tags = {
    Owner       = "user"
    Environment = "dev"
  }

to

maintenance_window      = "Mon:00:00-Mon:03:00"
  backup_window           = "03:00-06:00"
  backup_retention_period = 0 // disable backups to create DB faster

  tags = {
    Owner       = "user"
    Environment = "dev"
  }

seems to be non-compliant with the way Terraform 0.11 expects files to be formatted. This is the output I get from terraform fmt -diff=true:

-  backup_retention_period = 0 // disable backups to create DB faster
+  backup_retention_period = 0                                         // disable backups to create DB faster
antonbabenko pushed a commit that referenced this issue Aug 27, 2019
@antonbabenko
Copy link
Member

Thanks, Joey!

v1.32.0 has been just released.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants