Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update terraform-docs to 0.14.1 #52

Merged
merged 1 commit into from
Jul 22, 2021
Merged

feat: update terraform-docs to 0.14.1 #52

merged 1 commit into from
Jul 22, 2021

Conversation

bogaertg
Copy link
Contributor

@bogaertg bogaertg commented Jul 7, 2021

Description of your changes

I have:

How has this code been tested

@bogaertg
Copy link
Contributor Author

poke @Dirrk @khos2ow

@khos2ow
Copy link
Member

khos2ow commented Jul 19, 2021

Thank you @bogaertg and sorry for the delay!

gh-actions is a bit behind of terraform-docs core version and to make sure every version is covered we cannot skip versions (i.e. v0.13.0 and v0.14.0 are missing prior to this PR). And also I need to finish up #46 prior v0.7.0 (equivalent of terraform-docs v0.13.0).

That said, in the meantime that I finish up the rest of them to be able to proceed with your PR, there are two items are missing:

  • update of REAMDE is missing in this PR (take a look at b2fd336 for instance)
  • upgrade v0.13.0 -> v0.14.0

Please let me know if you're up to submit another PR for the latter. Otherwise I'll get around to them and come back to this PR shortly after the rest of them were done.

@khos2ow khos2ow linked an issue Jul 19, 2021 that may be closed by this pull request
Copy link
Member

@khos2ow khos2ow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bogaertg please go ahead and rebase your PR. Also please update README.md and .github/templates/README.tpl with new v0.14.1 version.

@bogaertg
Copy link
Contributor Author

I'm on vacation until 8th August. I will do this when I'm back unless someone is faster than me 😜

@khos2ow
Copy link
Member

khos2ow commented Jul 22, 2021

Ah, have fun! If you'd like I can fix the conflict here, just make sure you allow access to maintainers (by checking the box on the right)

Signed-off-by: Gaetan BOGAERT <gbogaert62@gmail.com>
Signed-off-by: Khosrow Moossavi <khos2ow@gmail.com>
@khos2ow khos2ow merged commit db05c81 into terraform-docs:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub action is behind terraform-docs
2 participants