fix: replacing deprecated set-output to use env instead #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasehlert
changed the title
Signed-off-by: Tobias Lindberg <tobias.ehlert@gmail.com>
|
It would be super lovely if this PR was approved and merged |
Closed
khos2ow
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Thank you @tobiasehlert and sorry for the very long delay getting back to this! Your change looks good to me, but it appears the whole repo needs some love. I'm gonna merge your PR as is and will fix the issues on another PR.
|
Thanks for the fix - would be good to tag a release, so downstream projects aren't at risk of failing on May31st. Thanks! |
|
@khos2ow is there any progress on the repo updates here? Looks like we've got about 2 weeks left and this will begin blocking pipelines |
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Replacing deprecated
set-outputto use env$GITHUB_OUTPUTinstead.Blogg post about deprecation:
https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
I have: